Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/fb_likebox 4190c1c30b675b9c9e2ede23d4858662b3bf50b3
source : http://cgit.drupalcode.org/fb_likebox
Pareview checklist:
https://pareview.sh/pareview/https-git.drupal.org-project-fb_likebox-8.x...
Comments
Comment #2
vuilComment #3
vuilComment #4
SerShevchykdrupal-check modules/contrib/fb_likebox
3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ---------------------------------------------------------
Line src/Tests/FBLikeboxBlockTest.php
------ ---------------------------------------------------------
12 Class Drupal\fb_likebox\Tests\FBLikeboxBlockTest extends deprecated class Drupal\simpletest\WebTestBase:
in Drupal 8.8.0 and will be removed before Drupal 9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
25 Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
in Drupal 8.8.0 and will be removed before Drupal 9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
------ ---------------------------------------------------------
[ERROR] Found 2 errors
Comment #5
SerShevchykComment #6
naveenvalechaComment #8
naveenvalechaThe Patch is green. Committed to 8.x-2.x
Comment #10
vuilI added my current employer!
Comment #11
akram zairig CreditAttribution: akram zairig as a volunteer commentedThis patch is not working :/
Comment #12
fenstratThis was committed here in #7, so no need for the patch, just need to use the dev version to run in D9.
Would be really good to get a new release cut.
Comment #13
Coops_+1 for getting a tagged release for this for D9