Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.It is unclear if the base path is relative to the Drupal installation or the web root.
Therefore the field needs a description
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | add_description_to_base_path_field-3106349-10.patch | 2.46 KB | a.dmitriiev |
| #9 | add_description_to_base_path_field-3106349-9.patch | 1.65 KB | ahebrank |
| #2 | 3106349-add_description_to_base_path_field.patch | 589 bytes | breidert |
Comments
Comment #2
breidert CreditAttribution: breidert at 1xINTERNET commentedComment #3
a.dmitriiev CreditAttribution: a.dmitriiev as a volunteer and at 1xINTERNET commentedComment #4
breidert CreditAttribution: breidert at 1xINTERNET commentedComment #5
ahebrank CreditAttribution: ahebrank commentedIn our case, it's not the Drupal root -- it's the root of the source repository. Maybe wording like "This path will be prefixed to config files when generating the patch. Depending on your needs, the path might be relative to the root of the Drupal installation or the root of the source repository." ?
Let's also validate the config path here, too, to ensure that it's relative and there's no leading
/on the path.Comment #6
ahebrank CreditAttribution: ahebrank commentedComment #7
ahebrank CreditAttribution: ahebrank commentedComment #8
ahebrank CreditAttribution: ahebrank commentedComment #9
ahebrank CreditAttribution: ahebrank commentedComment #10
a.dmitriiev CreditAttribution: a.dmitriiev as a volunteer and at 1xINTERNET commentedValidation works properly and the new wording is more clear. I've also noticed one @TODO in the form and resolved it in the following patch. Please review and test.
Comment #12
ahebrank CreditAttribution: ahebrank commentedThanks!