Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hi,
Please fix pareview.sh issues: https://pareview.sh/pareview/https-git.drupal.org-project-draggable_dash...
Review of the 8.x-1.x branch (commit d40f4b7):
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
ESLint has found some issues with your code (please check the JavaScript coding standards). See attachment.
DrupalPractice has found some issues with your code, but could be false positives.
FILE: .../drupal/pareviewsh/pareview_temp/src/Plugin/Block/DraggableBlock.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------
69 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
69 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
98 | WARNING | Unused variable $key.
113 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
131 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
133 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
174 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------
FILE: ...viewsh/pareview_temp/src/Controller/DraggableDashboardController.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
36 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------
FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Form/DashboardManageForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
155 | WARNING | Unused variable $delta.
--------------------------------------------------------------------------
Time: 1.28 secs; Memory: 4Mb
No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.
FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/assets/css/frontend.css
--------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------
2 | ERROR | [x] Expected 1 space after colon in style definition; 0
| | found
3 | ERROR | [x] Expected 1 space after colon in style definition; 0
| | found
4 | ERROR | [x] Expected 1 space after colon in style definition; 0
| | found
5 | ERROR | [x] Expected 1 space after colon in style definition; 0
| | found
8 | ERROR | [x] Expected 1 space before opening brace of class
| | definition; 0 found
26 | ERROR | [x] Expected 1 space before opening brace of class
| | definition; 0 found
99 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/assets/css/main.css
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
4 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/draggable_dashboard.module
--------------------------------------------------------------------------
FOUND 20 ERRORS AND 4 WARNINGS AFFECTING 20 LINES
--------------------------------------------------------------------------
39 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
41 | ERROR | [x] There should be no white space after an opening "("
41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
41 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
42 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
44 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found
51 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
52 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
53 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
63 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
64 | ERROR | [x] Equals sign not aligned with surrounding
| | assignments; expected 1 space but found 2 spaces
65 | WARNING | [x] A comma should follow the last multiline array item.
| | Found:
| | 'Drupal\draggable_dashboard\Controller\DraggableDashboardController::assignBlock'
69 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
79 | ERROR | [x] Short array syntax must be used to define arrays
87 | ERROR | [x] Doc comment short description must end with a full
| | stop
90 | ERROR | [x] Short array syntax must be used to define arrays
90 | ERROR | [x] The first index in a multi-value array must be on a
| | new line
91 | ERROR | [x] Short array syntax must be used to define arrays
92 | ERROR | [x] Short array syntax must be used to define arrays
96 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'draggable-dashboard-view'
97 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
104 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
104 | ERROR | [ ] Missing parameter comment
111 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 22 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: .../pareviewsh/pareview_temp/src/Plugin/Block/DraggableBlockDeriver.php
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
36 | ERROR | [x] There should be no white space after an opening "("
36 | ERROR | [x] There should be no white space before a closing ")"
36 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
40 | ERROR | [x] Array indentation error, expected 10 spaces but found
| | 12
41 | ERROR | [x] Array indentation error, expected 10 spaces but found
| | 12
42 | ERROR | [x] Array indentation error, expected 10 spaces but found
| | 12
43 | ERROR | [x] Array indentation error, expected 10 spaces but found
| | 12
44 | ERROR | [x] Array closing indentation error, expected 8 spaces but
| | found 10
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: .../drupal/pareviewsh/pareview_temp/src/Plugin/Block/DraggableBlock.php
--------------------------------------------------------------------------
FOUND 27 ERRORS AND 6 WARNINGS AFFECTING 28 LINES
--------------------------------------------------------------------------
43 | ERROR | [ ] Missing short description in doc comment
48 | ERROR | [ ] Missing short description in doc comment
53 | ERROR | [ ] Parameter $title_resolver is not described in
| | comment
55 | ERROR | [x] There must be exactly one blank line before the tags
| | in a doc comment
55 | ERROR | [ ] Missing parameter comment
56 | ERROR | [ ] Missing parameter comment
56 | ERROR | [ ] Missing parameter type
57 | ERROR | [ ] Missing parameter comment
57 | ERROR | [ ] Missing parameter type
90 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
94 | ERROR | [x] Inline comments must start with a capital letter
94 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
95 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
97 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
98 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
99 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
104 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
105 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
108 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
122 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
125 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found
| | 15
130 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
137 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
142 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found
151 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $render
152 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
165 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 0
169 | WARNING | [x] A comma should follow the last multiline array item.
| | Found:
| | 'draggable_dashboard/draggable_dashboard.frontend'
170 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
171 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
175 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
216 | ERROR | [x] Expected 1 newline at end of file; 0 found
216 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 25 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...viewsh/pareview_temp/src/Controller/DraggableDashboardController.php
--------------------------------------------------------------------------
FOUND 81 ERRORS AND 1 WARNING AFFECTING 65 LINES
--------------------------------------------------------------------------
34 | ERROR | [ ] If the line declaring an array spans longer than 80
| | characters, each element should be broken into its
| | own line
44 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
45 | ERROR | [x] Array indentation error, expected 12 spaces but
| | found 14
46 | ERROR | [x] Array indentation error, expected 12 spaces but
| | found 14
48 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
49 | ERROR | [x] Array indentation error, expected 12 spaces but
| | found 14
50 | ERROR | [x] Array indentation error, expected 12 spaces but
| | found 14
52 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
53 | ERROR | [x] Array indentation error, expected 12 spaces but
| | found 14
54 | ERROR | [x] Array indentation error, expected 12 spaces but
| | found 14
72 | ERROR | [ ] Missing short description in doc comment
73 | ERROR | [ ] Missing parameter comment
74 | ERROR | [ ] Missing parameter comment
76 | ERROR | [x] Expected 1 space before opening brace; found 0
77 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
77 | ERROR | [x] Inline comments must start with a capital letter
77 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
78 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
79 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
81 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
83 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
83 | ERROR | [x] Data types in @var tags need to be fully namespaced
84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
89 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
90 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
90 | ERROR | [x] Data types in @var tags need to be fully namespaced
91 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
92 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
92 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
93 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
93 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
95 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 8
95 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
96 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found
| | 10
96 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
97 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found
| | 12
98 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found
| | 12
99 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found
| | 12
100 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found
| | 10
101 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 8
102 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
103 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
104 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 8
107 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 0
109 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
110 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
110 | ERROR | [x] Inline comments must start with a capital letter
110 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
111 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
112 | ERROR | [x] Inline comments must start with a capital letter
112 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
113 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 6
116 | ERROR | [ ] Missing short description in doc comment
117 | ERROR | [ ] Missing parameter comment
117 | ERROR | [ ] Missing parameter type
118 | ERROR | [ ] Missing parameter comment
118 | ERROR | [ ] Missing parameter type
119 | ERROR | [ ] Description for the @return value is missing
119 | ERROR | [x] Data types in @return tags need to be fully
| | namespaced
121 | ERROR | [x] Expected 1 space before opening brace; found 0
122 | ERROR | [x] Data types in @var tags need to be fully namespaced
125 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
126 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
127 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
134 | ERROR | [x] Inline comments must start with a capital letter
134 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
161 | ERROR | [x] Data types in @var tags need to be fully namespaced
169 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
170 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
171 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
172 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
181 | ERROR | [x] Expected 1 blank line after function; 0 found
182 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 72 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Form/DashboardDeleteForm.php
--------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 8 LINES
--------------------------------------------------------------------------
7 | WARNING | [x] Unused use statement
36 | ERROR | [x] Doc comment short description must be on the first
| | line
38 | ERROR | [ ] Missing parameter comment
103 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
105 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
112 | ERROR | [x] Inline comments must start with a capital letter
112 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
114 | ERROR | [x] Inline comments must start with a capital letter
114 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
116 | ERROR | [x] Inline comments must start with a capital letter
116 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Form/DashboardManageForm.php
--------------------------------------------------------------------------
FOUND 18 ERRORS AND 9 WARNINGS AFFECTING 25 LINES
--------------------------------------------------------------------------
58 | ERROR | [x] Short array syntax must be used to define arrays
63 | ERROR | [x] Inline comments must start with a capital letter
63 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
69 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
78 | WARNING | [ ] Do not concatenate strings to translatable strings,
| | they should be part of the t() argument and you
| | should use placeholders
102 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
111 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $region
112 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
113 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
127 | ERROR | [x] Inline comments must start with a capital letter
127 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
129 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
130 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
131 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
213 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
219 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $links
220 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
242 | ERROR | [ ] Missing short description in doc comment
243 | ERROR | [ ] Missing parameter comment
244 | ERROR | [ ] Missing parameter comment
252 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
258 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
259 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
262 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
269 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $position
278 | ERROR | [x] Expected 1 blank line after function; 0 found
279 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 23 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Form/DashboardEditForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
6 | WARNING | [x] Unused use statement
7 | WARNING | [x] Unused use statement
57 | ERROR | [x] Expected 1 blank line after function; 0 found
58 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/DashboardAddForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
27 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ''
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Form/DashboardFormBase.php
--------------------------------------------------------------------------
FOUND 21 ERRORS AND 1 WARNING AFFECTING 17 LINES
--------------------------------------------------------------------------
18 | ERROR | [x] Function comment short description must start with
| | exactly one space
18 | ERROR | [x] Doc comment short description must end with a full
| | stop
45 | ERROR | [x] Doc comment short description must be on the first
| | line
47 | ERROR | [ ] Missing parameter comment
48 | ERROR | [ ] Missing parameter comment
102 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
140 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
146 | ERROR | [x] Inline comments must start with a capital letter
146 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
147 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
149 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
150 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
151 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
153 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
163 | ERROR | [x] Inline comments must start with a capital letter
163 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
168 | ERROR | [x] Inline comments must start with a capital letter
168 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
169 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
172 | ERROR | [x] Inline comments must start with a capital letter
172 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
173 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...drupal/pareviewsh/pareview_temp/draggable_dashboard.links.action.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
11 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...ndor/drupal/pareviewsh/pareview_temp/draggable_dashboard.routing.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
54 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
Time: 2.24 secs; Memory: 6Mb
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 3106467-code-standards-8.patch | 5.88 KB | a.dmitriiev |
| #3 | 3106467-coding-standards.patch | 53.21 KB | a.dmitriiev |
Comments
Comment #2
Ankush_03Comment #3
a.dmitriiev CreditAttribution: a.dmitriiev as a volunteer and at 1xINTERNET commentedHere is the patch with fixes attached. Please review.
Comment #4
a.dmitriiev CreditAttribution: a.dmitriiev as a volunteer and at 1xINTERNET commentedComment #6
cmd87 CreditAttribution: cmd87 at 1xINTERNET commentedThanks guys! Provided patch applied.
Comment #7
Ankush_03@a.dmitriiev and @cmd87
Still some issues not fixed.
Review of the 8.x-1.x branch (commit dc86ee0):
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
DrupalPractice has found some issues with your code, but could be false positives.
FILE: .../drupal/pareviewsh/pareview_temp/src/Plugin/Block/DraggableBlock.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
152 | WARNING | Unused variable $key.
--------------------------------------------------------------------------
Time: 1.31 secs; Memory: 4Mb
No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.
FILE: .../drupal/pareviewsh/pareview_temp/src/Plugin/Block/DraggableBlock.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
9 | WARNING | [x] Unused use statement
109 | ERROR | [ ] Type hint "array" missing for $plugin_definition
175 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found
| | 15
201 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...viewsh/pareview_temp/src/Controller/DraggableDashboardController.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------
27 | ERROR | [ ] Missing parameter comment
27 | ERROR | [x] Data types in @param tags need to be fully
| | namespaced
58 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
152 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
161 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
206 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Form/DashboardDeleteForm.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
36 | ERROR | Missing parameter comment
--------------------------------------------------------------------------
Time: 2.74 secs; Memory: 6Mb
Comment #8
a.dmitriiev CreditAttribution: a.dmitriiev as a volunteer and at 1xINTERNET commentedThe missing changes could be found in the new patch.
Comment #9
a.dmitriiev CreditAttribution: a.dmitriiev as a volunteer and at 1xINTERNET commentedComment #11
cmd87 CreditAttribution: cmd87 at 1xINTERNET commentedThanks guys! Provided patch applied.
Comment #12
Ankush_03@cmd87
Yes Pareview.sh issues resolved
If Everything working fine change status to fixed
Comment #13
cmd87 CreditAttribution: cmd87 at 1xINTERNET commentedComment #14
cmd87 CreditAttribution: cmd87 at 1xINTERNET commented