In order to be compatible with the upcoming 8.x-1.0-alpha4 release of Organic Groups we should now pass the user ID to MembershipManager::getMembership() rather than the full account object. Ref. https://github.com/Gizra/og/pull/541

Otherwise we will get the following deprecation notice:

Passing an account object is deprecated in og:8.1.0-alpha4 and is removed from og:8.1.0-beta1. Instead pass the user ID as an integer value. See https://github.com/Gizra/og/issues/542 in /home/cphp/data/container/52662a30-3835-493c-9597-caeda40204d5/workspace/web/modules/contrib/og/src/MembershipManager.php line 134

CommentFileSizeAuthor
#2 3069870-2.patch1.91 KBpfrenssen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Active » Needs review
FileSize
3069870-2.patch1.91 KB

Here is a patch. Note that this should only be committed once the 8.x-1.0-alpha4 release of OG is out.

mpp’s picture

mpp CreditAttribution: mpp at AmeXio for District09 commented
Status: Needs review » Reviewed & tested by the community
pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Postponed

Thanks for the quick review! This can be committed once OG 8.x-1.0-alpha4 is released. Marking as postponed.

  • pfrenssen committed 90df088 on 8.x-1.x 
    Issue #3069870 by pfrenssen: Passing the full account object is...
pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Postponed » Fixed

OG 8.x-1.0-alpha4 has been released, so this is ready to be merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.