Support from Acquia helps fund testing for Drupal Acquia logo

Comments

katherined created an issue. See original summary.

katherined’s picture

hchonov’s picture

"Unable to install modules: module 'autosave_form_test' is incompatible with this version of Drupal core."

It looks like we've forgot to update the test module to support D9.

hchonov’s picture

Status: Needs review » Needs work
katherined’s picture

Trying with addition of core_version_requirement to the test module.

katherined’s picture

Status: Needs work » Needs review
katherined’s picture

Remove 'core' key in autosave_form_test.info.yml

hchonov’s picture

I've just configured to module to support tests against Drupal 9.0.x. The core key however still can be kept, as the module was made D9 compatible in #3106255: Make module D9 compatible.

hchonov’s picture

I am not sure, but it might have been just a configuration thing from the administration page. Now the module will be tested weekly with the current core 9.0.x branch.

katherined’s picture

I'm getting this error, so I thought I'd try this.

Drupal\Core\Extension\InfoParserException: The 'core_version_requirement' constraint (9.0.0-dev) requires the 'core' key not be set in modules/contrib/autosave_form/tests/modules/autosave_form_test/autosave_form_test.info.yml

katherined’s picture

And that error is present on the latest test run: https://www.drupal.org/pift-ci-job/1625285

hchonov’s picture

So your patch from #5 was actually correct as there you've added the 'core_version_requirement: ^8 || ^9' to the test module, which should allow it to be installed on D9.

Could please upload a patch only with this change and queue it for a test on D9.

hchonov’s picture

Title: [ignore] Run tests against Drupal 9 » Run tests against Drupal 9
katherined’s picture

hchonov’s picture

Status: Needs review » Reviewed & tested by the community

  • hchonov committed b38485f on 8.x-1.x
    Issue #3109317 by katherined: Run tests against Drupal 9
    
hchonov’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-1.x. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

phenaproxima’s picture

Throwaway version of the patch which applies against the packaged version of 8.x-1.1.

Don't ask.