Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Testing to see if tests run against Drupal 9.
Comment | File | Size | Author |
---|---|---|---|
#19 | autosave_form-1.1-core-version-requirement.patch | 520 bytes | phenaproxima |
#14 | 3109317-14.patch | 430 bytes | katherined |
Comments
Comment #2
katherinedComment #3
hchonov"Unable to install modules: module 'autosave_form_test' is incompatible with this version of Drupal core."
It looks like we've forgot to update the test module to support D9.
Comment #4
hchonovComment #5
katherinedTrying with addition of core_version_requirement to the test module.
Comment #6
katherinedComment #7
katherinedRemove 'core' key in autosave_form_test.info.yml
Comment #8
hchonovI've just configured to module to support tests against Drupal 9.0.x. The core key however still can be kept, as the module was made D9 compatible in #3106255: Make module D9 compatible.
Comment #9
hchonovI am not sure, but it might have been just a configuration thing from the administration page. Now the module will be tested weekly with the current core 9.0.x branch.
Comment #10
katherinedI'm getting this error, so I thought I'd try this.
Drupal\Core\Extension\InfoParserException: The 'core_version_requirement' constraint (9.0.0-dev) requires the 'core' key not be set in modules/contrib/autosave_form/tests/modules/autosave_form_test/autosave_form_test.info.yml
Comment #11
katherinedAnd that error is present on the latest test run: https://www.drupal.org/pift-ci-job/1625285
Comment #12
hchonovSo your patch from #5 was actually correct as there you've added the 'core_version_requirement: ^8 || ^9' to the test module, which should allow it to be installed on D9.
Could please upload a patch only with this change and queue it for a test on D9.
Comment #13
hchonovComment #14
katherinedHere's a new patch.
Comment #15
hchonovComment #17
hchonovCommitted and pushed to 8.x-1.x. Thank you!
Comment #19
phenaproximaThrowaway version of the patch which applies against the packaged version of 8.x-1.1.
Don't ask.