CommentFileSizeAuthor
#6 unused-regions-3124087-6.patch444 byteskunalkapoor
#4 3124087-4.patch607 bytesNeslee Canil Pinto
#3 Screen Shot 2020-04-05 at 10.40.19 PM.png14.87 KBdjsagar
#2 unused_regions_issue-3124087-2.patch669 byteskunalkapoor
Screen Shot 2020-04-01 at 5.16.13 PM.png64.23 KBdjsagar
screencapture-contrib-lndo-site-admin-structure-block-2020-04-01-17_16_25.png363.99 KBdjsagar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

djsagar created an issue. See original summary.

kunalkapoor’s picture

kunalkapoor CreditAttribution: kunalkapoor as a volunteer and at OpenSense Labs commented
Status: Active » Needs review
FileSize
unused_regions_issue-3124087-2.patch669 bytes

I have added a patch for this please let me know if it works.

djsagar’s picture

djsagar CreditAttribution: djsagar at OpenSense Labs commented
Status: Needs review » Needs work
FileSize
Screen Shot 2020-04-05 at 10.40.19 PM.png14.87 KB

Hi @kunalkapoor,

Patch is not applied please rework for this issue.

Thanks!

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs work » Needs review
FileSize
3124087-4.patch607 bytes
kunalkapoor’s picture

kunalkapoor CreditAttribution: kunalkapoor as a volunteer and at OpenSense Labs commented
Status: Needs review » Needs work

The patch above is not working, please review the issue.

kunalkapoor’s picture

kunalkapoor CreditAttribution: kunalkapoor as a volunteer and at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
unused-regions-3124087-6.patch444 bytes

I have added a patch for this issue, please let me know if it works.

djsagar’s picture

djsagar CreditAttribution: djsagar at OpenSense Labs commented
Status: Needs review » Reviewed & tested by the community

Patch no #6 is applied successfully

Thanks

  • kunalkapoor committed 8d661e5 on 8.x-1.x 
    Issue #3124087 by kunalkapoor, Neslee Canil Pinto, djsagar: Remove...
kunalkapoor’s picture

kunalkapoor CreditAttribution: kunalkapoor as a volunteer and at OpenSense Labs commented
Status: Reviewed & tested by the community » Fixed
kunalkapoor’s picture

kunalkapoor CreditAttribution: kunalkapoor as a volunteer and at OpenSense Labs commented
Status: Fixed » Closed (fixed)
redseujac’s picture

redseujac
he/him/his
Primary language Dutch
Location Ieper, BE 🇧🇪
CreditAttribution: redseujac commented

Why did you remove those regions? When slideshow is enabled they are necessary to show the website mission (region Highlighted) and the website slogan (preface top). I had to add those regions again.