t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead

CommentFileSizeAuthor
#4 interdiff_2-4.txt384 bytesneelam_wadhwani
#4 3125960-4.patch1.55 KBneelam_wadhwani
#2 3125960-2.patch1.58 KBneelam_wadhwani
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neelam_wadhwani created an issue. See original summary.

neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
Assigned: neelam_wadhwani » Unassigned
Status: Needs work » Needs review
FileSize
3125960-2.patch1.58 KB

Kindly review patch.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs review » Needs work

@neelam_wadhwani, thanks for the patch, I can see whitespace in line 14, can you please remove it. Thanks.

neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
FileSize
3125960-4.patch1.55 KB
interdiff_2-4.txt384 bytes

I have worked for it.
Kindly review updated patch

neelam_wadhwani’s picture

neelam_wadhwani CreditAttribution: neelam_wadhwani at Valuebound for Valuebound commented
Status: Needs work » Needs review

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs review » Fixed

Committed, Thanks.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Fixed » Closed (fixed)