--------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
54 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
55 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
73 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
144 | WARNING | Unused variable $id.
-------------------------------------------------------------------------
Comment | File | Size | Author |
---|---|---|---|
#29 | 3116139-29.patch | 2.13 KB | suzymasri |
| |||
#20 | 3116139-20.patch | 4.83 KB | pradeepjha |
#15 | 3116139-15.patch | 4.92 KB | Manuel Garcia |
| |||
#15 | interdiff-3116139-10-15.txt | 651 bytes | Manuel Garcia |
#10 | 3116139-10.patch | 4.92 KB | rlhawk |
Comments
Comment #2
pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commentedInterface Drupal\key\Plugin\KeyPluginInterface extends deprecated interface Drupal\Component\Plugin\ConfigurablePluginInterface:
Drupal\Component\Plugin\ConfigurablePluginInterface is deprecated
in Drupal 8.7.0 and will be removed before Drupal 9.0.0. You should implement
ConfigurableInterface and/or DependentPluginInterface directly as needed. If
you implement ConfigurableInterface you may choose to implement
ConfigurablePluginInterface in Drupal 8 as well for maximum compatibility,
however this must be removed prior to Drupal 9.
Comment #3
pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commentedComment #4
suzymasriUpdated drupal-check report:
65/65 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ------------------------------------------------
Line /drush/key_delete.drush.inc
------ ------------------------------------------------
29 Call to deprecated function drush_log().
46 Call to deprecated function drush_log().
------ ------------------------------------------------
------ ------------------------------------------------------
Line drush/key_list.drush.inc
------ ------------------------------------------------------
19 Call to deprecated function _convert_csv_to_array():
Use \Drush\StringUtils::csvToArray
29 Call to deprecated function _convert_csv_to_array():
Use \Drush\StringUtils::csvToArray
------ ------------------------------------------------------
------ ----------------------------------------------
Line drush/key_save.drush.inc
------ ----------------------------------------------
36 Call to deprecated function drush_log().
97 Call to deprecated function drush_log().
------ ----------------------------------------------
------ ----------------------------------------------------------------------------
Line src/Plugin/KeyPluginInterface.php
------ ----------------------------------------------------------------------------
12 Interface Drupal\key\Plugin\KeyPluginInterface extends deprecated interface Drupal\Component\Plugin\ConfigurablePluginInterface:
Drupal\Component\Plugin\ConfigurablePluginInterface is deprecated
in Drupal 8.7.0 and will be removed before Drupal 9.0.0. You should implement
ConfigurableInterface and/or DependentPluginInterface directly as needed. If
you implement ConfigurableInterface you may choose to implement
ConfigurablePluginInterface in Drupal 8 as well for maximum compatibility,
however this must be removed prior to Drupal 9.
------ ----------------------------------------------------------------------------
------ ----------------------------------------------------------------------------
Line src/Plugin/KeyType/EncryptionKeyType.php
------ ----------------------------------------------------------------------------
110 Call to deprecated method randomBytes() of class Drupal\Component\Utility\Crypt:
in drupal:8.8.0 and is removed from drupal:9.0.0.
Use PHP's built-in random_bytes() function instead.
------ ----------------------------------------------------------------------------
[ERROR] Found 8 errors
Comment #5
suzymasriPatch attached.
Comment #6
suzymasriComment #7
Arlina CreditAttribution: Arlina at Chapter Three for Apigee commented#5 works against Drupal 9.0.0-beta2.
Comment #8
rlhawkThe work around ConfigurablePluginInterface was done in #3076926: Replace dependency on deprecated ConfigurablePluginInterface and is RTBC. I had committed it a while back, but it broke compatibility with Drupal versions <= 8.6, so it was reverted. Now that 8.6 is not longer supported, we can go forward with it. I will create a release that contains existing commits, which will be the last release that will work on 8.6. We should use
core_version_requirement: ^8.7.0 || ^9
in the .info file.Comment #9
rlhawkHere's a rerolled patch with the duplicate changes from #3076926: Replace dependency on deprecated ConfigurablePluginInterface removed. It also adds
core_version_requirement: ^8.7.0 || ^9
to the info.yml file and"drupal/core": "^8.7.0 || ^9"
as a requirement in composer.json.Comment #10
rlhawkComment #11
timmillwoodRunning tests with PHP 7
Comment #13
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commentedJust wanted to point out that the deprecations on
*.drush.inc
are because these are the legacy Drush 8 commands and these have already been migrated to Drush 9 (see KeyCommands) so its up to the maintainers to decide when to drop support for Drush 8. Looking at this https://docs.drush.org/en/master/install/#drupal-compatibility one could make an argument that any time would in theory be ok.Comment #14
heddnListing 8.7.0 won't work. The minimum is 8.7.7. And make sure when adding tests that we use the right version ranges of PHP. Drupal 8.8 requires 7.2. D9 requires 7.3.
Comment #15
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commentedRe #14 good points. Hopefully this will do the trick.
Comment #16
jcnventura CreditAttribution: jcnventura at 1xINTERNET commentedWould it not be better to use
$this->logger
instead of\Drupal::logger
in Drush commands?Comment #17
jcnventura CreditAttribution: jcnventura at 1xINTERNET commentedStill missing this one:
12 Interface Drupal\key\Plugin\KeyPluginInterface extends deprecated interface Drupal\Component\Plugin\ConfigurablePluginInterface:
Drupal\Component\Plugin\ConfigurablePluginInterface is deprecated
in Drupal 8.7.0 and will be removed before Drupal 9.0.0. You should implement
ConfigurableInterface and/or DependentPluginInterface directly as needed. If
you implement ConfigurableInterface you may choose to implement
ConfigurablePluginInterface in Drupal 8 as well for maximum compatibility,
however this must be removed prior to Drupal 9.
Looking at the code, we need to extend ConfigurableInterface
Comment #18
pradeepjha CreditAttribution: pradeepjha at Srijan | A Material+ Company for Drupal India Association commentedComment #19
jcnventura CreditAttribution: jcnventura at 1xINTERNET commentedI believe #17 has been done in #3076926: Replace dependency on deprecated ConfigurablePluginInterface.
Comment #20
pradeepjha CreditAttribution: pradeepjha at Srijan | A Material+ Company for Drupal India Association commentedUsed $this->logger instead of \Drupal::logger on #15 patch based on #16 comment.
Comment #21
AaronBauman#20 looks good to me
Comment #22
jcnventura CreditAttribution: jcnventura at 1xINTERNET commentedComment #23
rishab.singh CreditAttribution: rishab.singh as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedComment #24
rishab.singh CreditAttribution: rishab.singh as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedHi @pradeepjha
I have tested this patch and moving this to RTBC. #20 Patch looks good to me!
Comment #25
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commentedThanks all, just queued tests to run with the versions we're adding support to to see where we stand.
Comment #26
jcnventura CreditAttribution: jcnventura at 1xINTERNET commentedThanks for this. RTBC++
Comment #28
rlhawkThanks, everybody.
Comment #29
suzymasri@rlhawk Thanks for committing this!
I tested the dev branch and Travis is failing with below PHP compatibility issues related to using
$this->logger
that was added in #20:Patch attached to remove
$this->logger
and use\Drupal::logger
instead.Comment #30
pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commentedComment #31
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commentedThanks @suzymasri - the patch on 29 looks good to me.
Comment #32
pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commentedComment #34
rlhawkThanks, @suzymasri.
Comment #36
AaronBaumanIs there a release plan for stable D9 compatible version?
Any blockers I can help with?
I can't push a stable D9 release of my own module, which depends on Key, until Key has a stable D9 compatible release.