Views RSS Feed Authentication provides authentication support for the RSS search results which are generated by the views. This module depends on Simple OAuth(contribute) and HTTP Basic Authentication(core) modules.
Usually we use RSS feed URLs in openSearch or federated search concepts, in such scenarios we have to protect the RSS feed search pages using some authentication methods. So Views RSS Feed Authentication will provide the authentication for the RSS feed search pages which are implemented using Drupal views.
Dependencies
- HTTP Basic Authentication (core)
- Views (core)
- Simple OAuth (third-party)
Project link
https://www.drupal.org/project/vrssfa
Git instructions
git clone --branch 8.1.x https://git.drupalcode.org/project/vrssfa.git
PAReview checklist
https://pareview.sh/pareview/https-git.drupal.org-project-vrssfa.git-8.1.x
Comments
Comment #2
ramu_bharu CreditAttribution: ramu_bharu commentedComment #3
ramu_bharu CreditAttribution: ramu_bharu commentedComment #4
ramu_bharu CreditAttribution: ramu_bharu commentedComment #5
kuldeep_mehra27 CreditAttribution: kuldeep_mehra27 at Valuebound for Valuebound commentedThanks for contribution :)
Here is a brief summary of the issues found from the Automated Review.
https://pareview.sh/pareview/https-git.drupal.org-project-vrssfa.git
FILE: ...pareviewsh/pareview_temp/src/Routing/RouteSubscriberViewsrssFeed.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
19 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
21 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
21 | WARNING | Unused variable $current_path.
23 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
29 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------
FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/ViewsRssSettingsForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
36 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
37 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
68 | WARNING | Messages are user facing text and must run through t()
| | for translation
--------------------------------------------------------------------------
FILE: ...00/site1101/web/vendor/drupal/pareviewsh/pareview_temp/vrssfa.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
1 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...pareviewsh/pareview_temp/src/Routing/RouteSubscriberViewsrssFeed.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
36 | ERROR | [x] Short array syntax must be used to define arrays
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
42 | ERROR | [x] Closing brace indented incorrectly; expected 2 spaces,
| | found 1
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/ViewsRssSettingsForm.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
12 | ERROR | [x] Missing class doc comment
15 | ERROR | [x] There must be no blank lines after the function comment
65 | ERROR | [x] Object operator not indented correctly; expected 6
| | spaces but found 9
69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
69 | ERROR | [x] Closing brace indented incorrectly; expected 2 spaces,
| | found 1
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
Comment #6
kuldeep_mehra27 CreditAttribution: kuldeep_mehra27 at Valuebound for Valuebound commentedComment #7
ankushgautam76@gmail.comComment #8
ramu_bharu CreditAttribution: ramu_bharu commentedComment #9
apadernoThank you for applying! I added the Git instructions for non-maintainer users and the PAReview checklist link.
If you haven't done it, yet, please check the PAReview report and fix what needs to be fixed. There could be some false positives; verify that what reported is correct, before making any change.
Comment #10
apadernoComment #11
ramu_bharu CreditAttribution: ramu_bharu commentedHi,
I have made some changes and deployed to the current branch(8.1.x) .
Please review and advise.
Thanks,
Ramu
Comment #12
shaktikHi ramu_bharu,
Thanks for your contribution!
still have some issues, please fix.
Review of the 8.1.x branch (commit 59b1314):
hook_help()
. See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .This automated report was generated with PAReview.sh, your friendly project application review script.
Comment #13
ramu_bharu CreditAttribution: ramu_bharu as a volunteer commentedPlease provide suggestions on the warnings "\Drupal calls should be avoided in classes, use
| | dependency injection instead"
Comment #14
ramu_bharu CreditAttribution: ramu_bharu as a volunteer commentedComment #15
ramu_bharu CreditAttribution: ramu_bharu as a volunteer commentedHi,
I have made some changes and deployed to the current branch(8.1.x) .
Please review and advise.
Thanks,
Ramu
Comment #16
ramu_bharu CreditAttribution: ramu_bharu as a volunteer commentedComment #17
abhijeet.kumar2107 CreditAttribution: abhijeet.kumar2107 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented../vendor/bin/drupal-check modules/contrib/vrssfa/ -ad
3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] No errors
Comment #18
rohit-rajput-sahab CreditAttribution: rohit-rajput-sahab commentedhttps://pareview.sh/pareview/https-git.drupal.org-project-vrssfa.git-8.1...
Pareview is not resolved. Please resolve all issues.
Comment #19
rohit-rajput-sahab CreditAttribution: rohit-rajput-sahab commentedComment #20
ramu_bharu CreditAttribution: ramu_bharu as a volunteer commentedHi,
I have made some changes and deployed to the current branch(8.1.x) .
Please review the changes.
Thanks,
Ramu
Comment #21
ramu_bharu CreditAttribution: ramu_bharu as a volunteer commentedComment #22
ramu_bharu CreditAttribution: ramu_bharu as a volunteer and commentedHi kiamlaluno,
Can you review this please?
Thanks,
Ramu
Comment #23
rohit-rajput-sahab CreditAttribution: rohit-rajput-sahab commented@ramu_bharu Still pending
https://pareview.sh/pareview/https-git.drupal.org-project-vrssfa.git-8.1.x
FILE: ...pareviewsh/pareview_temp/src/Routing/RouteSubscriberViewsrssFeed.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
19 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
21 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
28 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------
Time: 251ms; Memory: 4Mb
Comment #24
ramu_bharu CreditAttribution: ramu_bharu as a volunteer and commentedHi Rohit,
Thanks very much for reviewing this module.
The dependency injection issues have been fixed and deployed to the current branch(8.1.x) .
Please review the latest changes.
Thanks,
Ramu
Comment #25
apadernoRemember to change status when the code has been fixed.
Comment #26
ramu_bharu CreditAttribution: ramu_bharu as a volunteer and commentedThanks very much kiamlaluno.
Comment #27
ramu_bharu CreditAttribution: ramu_bharu as a volunteer and commentedHi,
Please review the latest changes.
Thanks,
Ramu
Comment #28
apadernoComment #29
apadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #30
ramu_bharu CreditAttribution: ramu_bharu as a volunteer and commentedThanks very much kiamlaluno!!