Work being done at https://github.com/pantheon-systems/pantheon_advanced_page_cache/pull/26

web/modules/contrib/pantheon_advanced_page_cache/tests/behat/helper_classes/Contexts/FeatureContext.phpClass
Drupal\DrupalExtension\Context\RawDrupalContext not found and could not be autoloaded.

web/modules/contrib/pantheon_advanced_page_cache/tests/behat/helper_classes/Contexts/FeatureContext.php
Class Drupal\DrupalExtension\Context\RawDrupalContext not found and could not be autoloaded.

web/modules/contrib/pantheon_advanced_page_cache/tests/behat/helper_classes/tests/AgeTrackerTest.php
Class PHPUnit\Framework\TestCase not found and could not be autoloaded.

web/modules/contrib/pantheon_advanced_page_cache/tests/behat/helper_classes/tests/AgeTrackerTest.php
Class PHPUnit\Framework\TestCase not found and could not be autoloaded.

web/modules/contrib/pantheon_advanced_page_cache/pantheon_advanced_page_cache.info.yml
Add core_version_requirement: ^8 || ^9 to pantheon_advanced_page_cache.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

CommentFileSizeAuthor
#5 pantheon_advanced_page_cache-n3135416-5.patch1.04 KBDamienMcKenna
#3 Screenshot from 2020-05-11 10-48-07.png13.01 KBpaulocs
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chris Matthews created an issue. See original summary.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented

Hello Chris Matthews. I think the deprecated lines that you posted doesn't match with the module Pantheon Advanced Page Cache.

I run drupal-console and what I could see is:

 Line   tests/behat/helper_classes/Contexts/FeatureContext.php                                        
 ------ ---------------------------------------------------------------------------------------------- 
         Class Drupal\DrupalExtension\Context\RawDrupalContext not found and could not be autoloaded.  
         💡 Learn more at https://phpstan.org/user-guide/autoloading                                    
  15     Class Drupal\DrupalExtension\Context\RawDrupalContext not found and could not be autoloaded.  
         💡 Learn more at https://phpstan.org/user-guide/autoloading                                    
 ------ ----------------------------------------------------------------------------------------------
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
FileSize
Screenshot from 2020-05-11 10-48-07.png13.01 KB

After I installed drupal-extension, I run drupal-check.
There are no errors.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented
Issue summary: View changes
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Create Drupal 9 compatible release » Drupal 9 compatibility fixes for Pantheon Advanced Page Cache
Status: Active » Needs review
Issue tags: +Drupal 9 compatibility
FileSize
pantheon_advanced_page_cache-n3135416-5.patch1.04 KB

drupal-check isn't very thorough, e.g. it doesn't cover the info files.

stevector’s picture

stevector
he/him
CreditAttribution: stevector at Pantheon commented

Thanks all, I've merged the PR and the change is now available in the dev release.

stevector’s picture

stevector
he/him
CreditAttribution: stevector at Pantheon commented
Status: Needs review » Fixed
Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented

Thanks stevector, any chance you could go ahead and tag a D9 compatible 8.x-1.1 release?

stevector’s picture

stevector
he/him
CreditAttribution: stevector at Pantheon commented

I've tagged and released 8.x-1.1 here https://www.drupal.org/project/pantheon_advanced_page_cache/releases/8.x...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.