There's no need to name the primary key of the table "idmaillog", it should be just "id".

CommentFileSizeAuthor
#6 maillog-n3137940-6.patch1.5 KBDamienMcKenna
#2 maillog-n3137940-2.patch13.65 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
maillog-n3137940-2.patch13.65 KB

As proposed.

  • DamienMcKenna committed 4c79b52 on 7.x-1.x 
    Issue #3137940 by DamienMcKenna: Rename "idmaillog" field and variable...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Fixed » Needs work

This needs work, the update script fails.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
maillog-n3137940-6.patch1.5 KB

This seems to work in my local testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review

  • DamienMcKenna committed 2021002 on 7.x-1.x 
    Issue #3137940 by DamienMcKenna: Corrected update script.
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.