Hi there,

Some websites use a diferent theme for admin pages.

So it would nice to view those mail details in the same admin theme.

Changing the path from maillog/details to admin/maillog/details would achive this effect.

Thanks
Great work :)

CommentFileSizeAuthor
#13 maillog-n2831876-13.patch5.33 KBDamienMcKenna
#13 maillog-n2831876-13.interdiff.txt1.44 KBDamienMcKenna
#11 maillog-n2831876-11.patch4.91 KBDamienMcKenna
#3 change_path_from-2831876-3.patch3.1 KBcebasqueira
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

manoloka created an issue. See original summary.

cebasqueira’s picture

cebasqueira CreditAttribution: cebasqueira commented
Assigned: Unassigned » cebasqueira
cebasqueira’s picture

cebasqueira CreditAttribution: cebasqueira commented
Assigned: cebasqueira » Unassigned
Status: Active » Needs review
FileSize
change_path_from-2831876-3.patch3.1 KB

Status: Needs review » Needs work

The last submitted patch, 3: change_path_from-2831876-3.patch, failed testing.

The last submitted patch, 3: change_path_from-2831876-3.patch, failed testing.

The last submitted patch, 3: change_path_from-2831876-3.patch, failed testing.

The last submitted patch, 3: change_path_from-2831876-3.patch, failed testing.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Version: 7.x-1.0-alpha1 » 7.x-1.x-dev
Parent issue: » #1238994: Plan for MailLog 7.x-1.0 release

Agreed.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

This also needs an update script to rebuild the menu cache.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Change path from maillog/details to admin/maillog/details » Change callback paths to use the admin/reports/maillog base

I think it should also be "admin/reports/maillog/view/%maillog_maillog" and "admin/reports/maillog/delete/%maillog_maillog", matching the path structure of other systems.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
maillog-n2831876-11.patch4.91 KB

This covers both paths.

Status: Needs review » Needs work

The last submitted patch, 11: maillog-n2831876-11.patch, failed testing. View results

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
maillog-n2831876-13.interdiff.txt1.44 KB
maillog-n2831876-13.patch5.33 KB

Forgot to update the arguments to the menu callbacks. This seems to fix it.

  • DamienMcKenna committed 6a92606 on 7.x-1.x 
    Issue #2831876 by DamienMcKenna, cebasqueira: Change callback paths to...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.