There is a stray comma on line 230 of the current dev that is causing a fatal error w/ core 8.8.5 and php 7.2.
I discovered this when going to manage display for a node.

The patch in 3124286 didn't seem to address this.

Seems to have been introduced here:
https://git.drupalcode.org/project/field_redirection/commit/2f1f70d#4410...

Here's the backtrace:

The website encountered an unexpected error. Please try again later.
ParseError: syntax error, unexpected ')' in Composer\Autoload\includeFile() (line 231 of modules/contrib/field_redirection/src/Plugin/Field/FieldFormatter/FieldRedirectionFormatter.php).
Composer\Autoload\includeFile('/app/web/modules/contrib/field_redirection/src/Plugin/Field/FieldFormatter/FieldRedirectionFormatter.php') (Line: 322)
Composer\Autoload\ClassLoader->loadClass('Drupal\field_redirection\Plugin\Field\FieldFormatter\FieldRedirectionFormatter')
spl_autoload_call('Drupal\field_redirection\Plugin\Field\FieldFormatter\FieldRedirectionFormatter')
class_exists('Drupal\field_redirection\Plugin\Field\FieldFormatter\FieldRedirectionFormatter') (Line: 96)
Drupal\Component\Plugin\Factory\DefaultFactory::getPluginClass('field_redirection_formatter', Array) (Line: 800)
Drupal\field_ui\Form\EntityDisplayFormBase->getApplicablePluginOptions(Object) (Line: 310)
Drupal\field_ui\Form\EntityDisplayFormBase->buildFieldRow(Object, Array, Object) (Line: 40)
Drupal\field_ui\Form\EntityViewDisplayEditForm->buildFieldRow(Object, Array, Object) (Line: 224)
Drupal\layout_builder\Form\LayoutBuilderEntityViewDisplayForm->buildFieldRow(Object, Array, Object) (Line: 218)
Drupal\field_ui\Form\EntityDisplayFormBase->form(Array, Object) (Line: 47)
Drupal\layout_builder\Form\LayoutBuilderEntityViewDisplayForm->form(Array, Object) (Line: 149)
Drupal\Core\Entity\EntityForm->buildForm(Array, Object) (Line: 40)
Drupal\layout_builder\Form\LayoutBuilderEntityViewDisplayForm->buildForm(Array, Object, Object)
call_user_func_array(Array, Array) (Line: 520)
Drupal\Core\Form\FormBuilder->retrieveForm('entity_view_display_edit_form', Object) (Line: 277)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 91)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 573)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 151)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 67)
Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 50)
Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 708)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

matt_paz created an issue. See original summary.

marcusml’s picture

I stumbled upon this as well. I've uploaded a patch which fixes the issue.

marcusml’s picture

Status: Active » Needs review
Nebel54’s picture

Status: Needs review » Reviewed & tested by the community

Removing the comma (patch #2) fixes the issue.

UlfG’s picture

Removing the comma (patch #2) fixes the issue for me as well

jwilson3’s picture

RTBC++ Let's get this in. 2.0-rc1 is unusable without it.

jwilson3’s picture

jwilson3’s picture

Title: Another fatal error in formatter? » PHP Syntax error in formatter: unexpected ')'

DamienMcKenna’s picture

Status: Reviewed & tested by the community » Fixed

Committed. I'll tag rc2 with this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.