CommentFileSizeAuthor
#3 prevent_homepage_deletion_3138242_3.patch2.86 KBJoshaHubbers
#2 3138242-fix-parmission-machine-name.patch750 bytesfirass.ziedan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Firass Ziedan created an issue. See original summary.

firass.ziedan’s picture

firass.ziedan
Location Jordan
CreditAttribution: firass.ziedan at Vardot commented
Assigned: firass.ziedan » Unassigned
Status: Active » Needs review
FileSize
3138242-fix-parmission-machine-name.patch750 bytes
JoshaHubbers’s picture

JoshaHubbers CreditAttribution: JoshaHubbers at iO commented
FileSize
prevent_homepage_deletion_3138242_3.patch2.86 KB

Thank you for this suggestion. Although your patch is not very complete, and not urgend, because in this issue #2309869: Use proper machine names for permissions the coding standard for permissions is still being discussed.
While your patch breaks the module, and tests, the idea is ok. So here is a working patch that i'll commit.

JoshaHubbers’s picture

JoshaHubbers CreditAttribution: JoshaHubbers at iO commented

  • JoshaHubbers committed 2c8ff09 on 8.x-1.x 
    Issue #3138242 by Firass Ziedan, JoshaHubbers: Fix permission machine...
JoshaHubbers’s picture

JoshaHubbers CreditAttribution: JoshaHubbers at iO commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.