Problem/Motivation

drupal-check .
 25/25 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------------------- 
  Line   src/Plugin/LanguageSelectionPageCondition/LanguageSelectionPageConditionBlacklistedPaths.php  
 ------ ---------------------------------------------------------------------------------------------- 
  76     Parameter $alias_manager of method                                                            
         Drupal\language_selection_page\Plugin\LanguageSelectionPageCondition\                         
         LanguageSelectionPageConditionBlacklistedPaths::__construct() has                             
         typehint with deprecated interface                                                            
         Drupal\Core\Path\AliasManagerInterface:                                                       
         in drupal:8.8.0 and is removed from drupal:9.0.0.                                             
         Use \Drupal\path_alias\AliasManagerInterface.                                                 
  131    Call to deprecated method strtolower() of class                                               
         Drupal\Component\Utility\Unicode:                                                             
         in drupal:8.6.0 and is removed from drupal:9.0.0. Use                                         
         mb_strtolower() instead.                                                                      
 ------ ---------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------- 
  Line   src/Plugin/LanguageSelectionPageCondition/LanguageSelectionPageConditionPath.php  
 ------ ---------------------------------------------------------------------------------- 
  105    Parameter $alias_manager of method                                                
         Drupal\language_selection_page\Plugin\LanguageSelectionPageCondition\             
         LanguageSelectionPageConditionPath::__construct() has typehint with               
         deprecated interface Drupal\Core\Path\AliasManagerInterface:                      
         in drupal:8.8.0 and is removed from drupal:9.0.0.                                 
         Use \Drupal\path_alias\AliasManagerInterface.                                     
  162    Call to deprecated function drupal_set_message():                                 
         in drupal:8.5.0 and is removed from drupal:9.0.0.                                 
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.              
 ------ ---------------------------------------------------------------------------------- 

                                                                                
 [ERROR] Found 4 errors

Remaining tasks

  • Remove deprecations listed above.
  • Add core_version_requirement property to language_selection_page.info.yml
CommentFileSizeAuthor
#11 interdiff-3124380-10-11.txt1.42 KBJeroenT
#11 3124380-11.patch11.4 KBJeroenT
#10 interdiff-3124380-9-10.txt1.94 KBJeroenT
#10 3124380-10.patch10.71 KBJeroenT
#9 interdiff-3124380-7-9.txt3.61 KBJeroenT
#9 3124380-9.patch12.52 KBJeroenT
#7 3124380-7.patch8.58 KBJeroenT
#6 3124380-6.patch8.42 KBJeroenT
#5 3124380-5.patch7.61 KBJeroenT
#2 3124380-1.patch2.35 KBShruthi Shetty M
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Shruthi Shetty M created an issue. See original summary.

Shruthi Shetty M’s picture

Shruthi Shetty M CreditAttribution: Shruthi Shetty M at Specbee commented
Status: Active » Needs review
FileSize
3124380-1.patch2.35 KB
Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol as a volunteer commented
Status: Needs review » Postponed (maintainer needs more info)

Hi,

I see you're now using mb_strtolower which requires the mbstring extension.
I also see that mbstring is a requirement for Drupal 8: https://www.drupal.org/docs/8/system-requirements/php-requirements

I guess that point is perfectly valid.

I also see that you replace drupal_set_message with $this->messenger->addMessage, is that property ($this->messenger) exists ?

Thanks.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Title: Remove the deprication function drupal_set_message() and method strtolower() » Drupal 9 Deprecated Code Report
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Needs work
Issue tags: +Drupal 9 compatibility, +Novice

Updated IS.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs work » Needs review
FileSize
3124380-5.patch7.61 KB
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
FileSize
3124380-6.patch8.42 KB
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
FileSize
3124380-7.patch8.58 KB
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented

Well, at least the tests are running. The test that is currently failing is locally already failing without any changes.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
FileSize
3124380-9.patch12.52 KB
interdiff-3124380-7-9.txt3.61 KB
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
FileSize
3124380-10.patch10.71 KB
interdiff-3124380-9-10.txt1.94 KB
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
FileSize
3124380-11.patch11.4 KB
interdiff-3124380-10-11.txt1.42 KB

  • Pol committed caf1641 on 8.x-2.x authored by JeroenT 
    Issue #3124380 by JeroenT, Shruthi Shetty M: Drupal 9 Deprecated Code...
Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol as a volunteer commented
Status: Needs review » Fixed

Thanks fellow mate :)

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Fixed » Needs work

Hi Pol,

Thanks for committing this issue. But it seems something went wrong on commit: https://git.drupalcode.org/project/language_selection_page/-/commit/caf1...

\Traversable was updated to Traversable, which now breaks the functionality of the module. Can you revert that change?

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol as a volunteer commented

Oops !! Fixed in 8.x-2.6 sorry about that.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs work » Fixed

Great!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.