Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
We should definitively complete this transition:
Comment | File | Size | Author |
---|---|---|---|
#11 | paragraphs-3080556-11.patch | 60.04 KB | Berdir |
#11 | paragraphs-3080556-11-interdiff.txt | 3.21 KB | Berdir |
#10 | paragraphs-3080556-10.patch | 59.97 KB | Berdir |
| |||
#9 | paragraphs-3080556-9.patch | 62.71 KB | bartlangelaan |
|
Comments
Comment #2
bartlangelaanThis patch switches the default widget, and changes the title & descriptions of the widgets.
Didn't run any test, so let's see which errors come up!
Comment #3
bartlangelaanComment #4
BerdirThanks!
A test would be useful that asserts that the stable one is chosen by default, I guess all our current tests currently specify it explicitly.
Also, we have a lot of *Experimental* test, we should probably rename them too, will result in some conflicts unfortunately. Probably not worth touching legacy/classic.
Comment #5
bartlangelaanThis replaces all references to the 'classic' and 'experimental' widget.
There is no new test for testing the default widget yet.
Comment #6
bartlangelaanComment #7
Berdirlooks like you added some .idea files to the patch.
So core actually disallows to use Legacy prefixed tests o.0
Another reason to keep them as they are as "Classic" then, for now anyway.
Comment #8
bartlangelaanFor the last patch, I made a quick adjustment to check if
LegacyWidget
was okay whenLegacy
wasn't, but everything that starts with\Legacy
is giving an error. I didn't have my tests set up locally so that's why I uploaded it, sorry for the trouble.In this patch, I changed it to
\WidgetLegacy
, which should be allowed.Also, I added a new test:
Drupal\Tests\paragraphs\Functional\ParagraphsUiTest::testDefaultWidget
It verifies that the 'paragraphs' widget is used by default.
Furthermore, cleaned up the patch.
I can revert the changes if you want, but they should work now. I think that we should keep the labels and test names consistent, so if you want the old widget to be marked as 'Legacy' as noted in the issue summary, we should also do that in the test names.
Comment #9
bartlangelaanRe-roll!
Comment #10
BerdirReroll.
Comment #11
BerdirUpdating the readme description a bit.
Comment #12
miro_dietikerWohooo, let's celebrate this! :-)
Comment #13
shelaneWhat commit was this fixed in? I was still seeing “EXPERIMENTAL” in the edit form display screen after updating to 1.12.
Comment #15
BerdirHm, somehow the commit isn't there. Not sure what happened. I pushed it again now.
Comment #17
mpp CreditAttribution: mpp at AmeXio for District09 commentedThe project page still lists the "experimental" and the "classic" widget. It should be updated with the same content as the readme.
The readme states:
" * Legacy (formerly Classic): a stable UI with limited features that will not be changed or updated."
Perhaps it would be more clear if the readme explicitly states that the classic widget is deprecated (and needs to be migrated to the stable widget)?