Add core_version_requirement: ^8 || ^9 to block_content_permissions.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

CommentFileSizeAuthor
#8 Screenshot from 2020-05-27 12-18-37.png99.06 KBpiggito
#6 3117955-6.patch1.04 KBGaurav_drupal
#2 3117955-2.patch316 bytespavnish
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pavnish created an issue. See original summary.

pavnish’s picture

pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commented
Assigned: pavnish » Unassigned
Status: Active » Needs review
FileSize
3117955-2.patch316 bytes
gambry’s picture

gambry
Primary language Italian
Location Milan
CreditAttribution: gambry at manifesto commented
Status: Needs review » Reviewed & tested by the community

Looks good. Thanks!

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

+1 on RTBC. Did a quick manual check of the code. There isn't any composer.json. No version specific code in here; so it looks like it can run on 8.x and 9.x of Drupal core without any hackery.

Gaurav_drupal’s picture

Gaurav_drupal
he/him
Primary language Hindi
Location Indore
CreditAttribution: Gaurav_drupal at Axelerant commented
Assigned: Unassigned » Gaurav_drupal
Status: Reviewed & tested by the community » Needs work 
Upgrade status report:
--------------------------------------------------------------------------------
Block Content Permissions

2 errors found. 1 warning found.

web/modules/contrib/block_content_permissions/src/Controller/BlockContentPermiss
ionsAddPageController.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 35   │ Call to deprecated method getStorage() of class              │
│         │      │ Drupal\Core\Entity\EntityManager. Deprecated in drupal:8.0.0 │
│         │      │ and is removed from drupal:9.0.0. Use                        │
│         │      │ Drupal\Core\Entity\EntityTypeManagerInterface::getStorage()  │
│         │      │ instead.                                                     │
│         │      │                                                              │
│ Fix now │ 36   │ Call to deprecated method getStorage() of class              │
│         │      │ Drupal\Core\Entity\EntityManager. Deprecated in drupal:8.0.0 │
│         │      │ and is removed from drupal:9.0.0. Use                        │
│         │      │ Drupal\Core\Entity\EntityTypeManagerInterface::getStorage()  │
│         │      │ instead.                                                     │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/block_content_permissions/block_content_permissions.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                         MESSAGE                          │
├──────────┼──────┼──────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add <code>core_version_requirement: ^8 || ^9

to │
│ manually │ │ block_content_permissions.info.yml to designate that the │
│ │ │ module is compatible with Drupal 9. See │
│ │ │ https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────┘

Gaurav_drupal’s picture

Gaurav_drupal
he/him
Primary language Hindi
Location Indore
CreditAttribution: Gaurav_drupal at Axelerant commented
Assigned: Gaurav_drupal » Unassigned
Status: Needs work » Needs review
FileSize
3117955-6.patch1.04 KB

Provided the patch, please review.

Gaurav_drupal’s picture

Gaurav_drupal
he/him
Primary language Hindi
Location Indore
CreditAttribution: Gaurav_drupal at Axelerant commented
piggito’s picture

piggito CreditAttribution: piggito as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screenshot from 2020-05-27 12-18-37.png99.06 KB

I checked last patch with drupal-check, Upgrade Status and Drupal Rector and it passed for all 3 tools so I'm adding RTBC

d9 tests

pavnish’s picture

pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commented

@Gaurav_drupal @piggito Thanks but the bug about only for "Add core version requirement support for drupal 9"
Add deprecation in this issue is not a good thing.

gambry’s picture

gambry
Primary language Italian
Location Milan
CreditAttribution: gambry at manifesto commented
Issue tags: +Needs issue summary update

That's fine @pavnish . We just need to update the Issue Summary to state this is for Drupal 9 compatibility.

pavnish’s picture

pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commented
Title: Add core version requirement support for drupal 9 » Drupal 9 compatibility
pavnish’s picture

pavnish CreditAttribution: pavnish at Srijan | A Material+ Company for Drupal India Association commented

@gambry Thanks
I have updated the issue summary.
Thanks
Pavnish

Mohammed J. Razem’s picture

Mohammed J. Razem
Location Santa Clara, CA
CreditAttribution: Mohammed J. Razem at Vardot commented

+1
Looks good! I have sent the maintainer joshua.roberson to urge a commit/release.

joshua.roberson’s picture

joshua.roberson CreditAttribution: joshua.roberson commented
Status: Reviewed & tested by the community » Fixed

This is on dev now.

joshua.roberson’s picture

joshua.roberson CreditAttribution: joshua.roberson commented
Status: Fixed » Closed (fixed)