Problem/Motivation

drupal-check results on commit hash: e0c9acb48f6cc441e3746dd6563ea483239a6b79


 

 ------ -------------------------------------------------------------------- 
  Line   tests/src/Functional/InstagramEmbedFormatterTest.php                
 ------ -------------------------------------------------------------------- 
  15     Usage of deprecated trait                                           
         Drupal\Tests\media\Functional\MediaFunctionalTestCreateMediaTypeTr  
         ait in class                                                        
         Drupal\Tests\media_entity_instagram\Functional\InstagramEmbedForma  
         tterTest.                                                           
  80     Call to deprecated function entity_get_display().                   
 ------ -------------------------------------------------------------------- 

 ------ ---------------------------------------------- 
  Line   tests/src/Unit/ConstraintsTest.php            
 ------ ---------------------------------------------- 
  48     Call to deprecated method getMock() of class  
         Drupal\Tests\UnitTestCase.                    
 ------ ---------------------------------------------- 

 [ERROR] Found 3 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 interdiff_7-10.txt5.63 KBkatherined
#10 drupal_9_deprecated_code-3042756-10.patch6.64 KBkatherined
#7 drupal_9_deprecated_code-3042756-7.patch2.4 KBkatherined
#4 drupal_9_deprecated_code-3042756-4.patch2.34 KBSergiu Stici
#2 drupal_9_deprecated_code-3042756-2.patch1.93 KBSergiu Stici
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mcdwayne created an issue. See original summary.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Active » Needs review
FileSize
drupal_9_deprecated_code-3042756-2.patch1.93 KB

Here is the patch, please review.

Status: Needs review » Needs work

The last submitted patch, 2: drupal_9_deprecated_code-3042756-2.patch, failed testing. View results

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Needs work » Needs review
FileSize
drupal_9_deprecated_code-3042756-4.patch2.34 KB

Status: Needs review » Needs work

The last submitted patch, 4: drupal_9_deprecated_code-3042756-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented

Patch does not apply and there are more deprecations than that:

------ ---------------------------------------------------------------------
  Line   media_entity_instagram.install
 ------ ---------------------------------------------------------------------
  14     Call to deprecated function file_prepare_directory():
         in Drupal 8.7.0, will be removed before Drupal 9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
  16     Call to deprecated function file_scan_directory():
         in drupal:8.8.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.
  25     Call to deprecated function file_unmanaged_copy():
         in Drupal 8.7.0, will be removed before Drupal 9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::copy().
 ------ ---------------------------------------------------------------------

 ------ ----------------------------------------------------------------
  Line   src/Plugin/media/Source/Instagram.php
 ------ ----------------------------------------------------------------
  177    Call to deprecated function file_prepare_directory():
         in Drupal 8.7.0, will be removed before Drupal 9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
  183    Call to deprecated function file_unmanaged_save_data():
         in Drupal 8.7.0, will be removed before Drupal 9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::saveData().
 ------ ----------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/InstagramEmbedFormatterTest.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  15     Usage of deprecated trait Drupal\Tests\media\Functional\MediaFunctionalTestCreateMediaTypeTrait in class Drupal\Tests\media_entity_instagram\Functional\InstagramEmbedFormatterTest:
         in Drupal 8.6.0 and will be removed before Drupal 9.0.0. Use
         \Drupal\Tests\media\Traits\MediaTypeCreationTrait instead.
  84     Call to deprecated function entity_get_display():
         in drupal:8.8.0 and will be removed from drupal:9.0.0. Use
         EntityDisplayRepositoryInterface::getViewDisplay() instead.
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------
  Line   tests/src/Unit/ConstraintsTest.php
 ------ -------------------------------------------------------------------------
  48     Call to deprecated method getMock() of class Drupal\Tests\UnitTestCase:
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Tests\PhpunitCompatibilityTrait::createMock() instead.
 ------ -------------------------------------------------------------------------
katherined’s picture

katherined
she/her
Primary language English
CreditAttribution: katherined commented
FileSize
drupal_9_deprecated_code-3042756-7.patch2.4 KB

reroll previous patch

katherined’s picture

katherined
she/her
Primary language English
CreditAttribution: katherined commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: drupal_9_deprecated_code-3042756-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

katherined’s picture

katherined
she/her
Primary language English
CreditAttribution: katherined commented
Status: Needs work » Needs review
FileSize
drupal_9_deprecated_code-3042756-10.patch6.64 KB
interdiff_7-10.txt5.63 KB

Thinking entity_get_display() should stay as-in until 8.8 is the minimum supported release.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Needs review » Reviewed & tested by the community

Thank you @katherined. It looks good to me now.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
CreditAttribution: chr.fritsch at Thunder commented
Status: Reviewed & tested by the community » Fixed

Done

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #3144543: Plan for Media Entity Instagram 8.x-2.x