FILE: /app/web/modules/contrib/front/README.txt
-----------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------
 15 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 30 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 34 | ERROR   | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: /app/web/modules/contrib/front/front_page.links.task.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 11 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/front/front_page.permissions.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 4 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/front/front_page.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 133 | ERROR | Type hint "array" missing for $variables
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/front/front_page.services.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 10 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/front/front_page.links.menu.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 17 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/front/src/Form/FrontPageSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AND 2 WARNINGS AFFECTING 12 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------
   5 | WARNING | [x] Unused use statement
   8 | WARNING | [x] Unused use statement
  18 | ERROR   | [ ] Public method name "FrontPageSettingsForm::getFormID" is not in lowerCamel format
  40 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  66 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  97 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 0
  97 | ERROR   | [x] 4 spaces found before inline comment; expected "// parent::validateForm($form, $form_state);" but found "//   
     |         |     parent::validateForm($form, $form_state);"
  97 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 114 | ERROR   | [x] No space found before comment text; expected "// Set if all config are enabled or not." but found "//Set if all config are
     |         |     enabled or not."
 117 | ERROR   | [x] No space found before comment text; expected "// Set config by role." but found "//Set config by role."
 119 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 5
 123 | ERROR   | [x] Closing brace indented incorrectly; expected 5 spaces, found 4
 127 | ERROR   | [x] Expected 1 blank line after function; 0 found
 128 | ERROR   | [x] The closing brace for the class must have an empty line before it
------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /app/web/modules/contrib/front/src/Form/FrontPageHomeLinksForm.php
----------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------
  7 | WARNING | [x] Unused use statement
 17 | ERROR   | [ ] Public method name "FrontPageHomeLinksForm::getFormID" is not in lowerCamel format
 41 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead
 56 | ERROR   | [x] Expected 1 blank line after function; 0 found
 57 | ERROR   | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: /app/web/modules/contrib/front/src/EventSubscriber/FrontPageSubscriber.php
------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------
 10 | ERROR | [x] When importing a class with "use", do not include a leading \
 47 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
 80 | ERROR | [x] Visibility must be declared on method "getSubscribedEvents"
 83 | ERROR | [x] Expected 1 blank line after function; 0 found
 84 | ERROR | [x] The closing brace for the class must have an empty line before it
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

Time: 177ms; Memory: 10MB
CommentFileSizeAuthor
#2 3152429-2.patch7.26 KBBunty Badgujar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bunty Badgujar created an issue. See original summary.

Bunty Badgujar’s picture

Assigned: Bunty Badgujar » Unassigned
Status: Active » Needs review
FileSize
7.26 KB

Patch to fix coding standard issues.

  • Bunty Badgujar authored 638ad14 on 8.x-1.x
    Issue #3152429 by Bunty Badgujar, Bunty Badgujar: Code standard issues
    
Oleksandr Senenko’s picture

Status: Needs review » Fixed

Looks good, thank you. Committed.

Oleksandr Senenko’s picture

Status: Fixed » Closed (fixed)