Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This patch removes the use of radio buttons to select the flag, and in turn makes the flag a regular argument (UI-wise) as shown in snap.png. This allows more complex configurations which are discussed here #298109-73: Rules integration.
The patch also adds a 'Load flag' action. A follow-up patch can include 'Add a flag'.
Comment | File | Size | Author |
---|---|---|---|
#4 | flag_rules_flag_as_argument_4.patch | 9.27 KB | amitaibu |
#3 | flag_rules_flag_as_argument_3.patch | 9.28 KB | amitaibu |
snap.png | 52.23 KB | amitaibu | |
flag_rules_flag_as_argument.patch | 7.83 KB | amitaibu | |
Comments
Comment #1
mooffie CreditAttribution: mooffie commentedIsn't this a dup of #394152: Improvement for the Rules integration?
Comment #2
amitaibuoops, I forgot I opened that issue :) I've closed it now as duplicate.
Comment #3
amitaibuSome more cleanup, and fix of calling wrong function.
Comment #4
amitaibuAnd this time the correct patch...
Comment #5
amitaibuand correct status... sigh.
Comment #6
looplog CreditAttribution: looplog commentedYour suggestion at #545788: create new flag on node submit was unfortunately beyond my understanding of how to trigger php on node save, so rules integration in regards to your suggested 'Add a flag' action would be ideal for my uses. Was wondering if you've had any progress with this patch?
Comment #7
BenK CreditAttribution: BenK commentedSubscribing....
Comment #8
Bilmar CreditAttribution: Bilmar commented+1 subscribing
Comment #9
quicksketchBenK and trupal218: Could you guys review this patch? I don't use or support Rules in any way, so the only way this will be committed will be if it is tested and reviewed by other users who use Rules. As a feature request, this sounds like something that will probably only go into the 2.x version, and so this patch will most likely need to be updated to match the latest code.
Comment #10
robby.smith CreditAttribution: robby.smith commentedsubscribing
Comment #11
robby.smith CreditAttribution: robby.smith commentedAgainst 6.x-1.x-dev
Against 6.x-2.0-beta3
Against 6.x-2.x-dev
Comment #12
robby.smith CreditAttribution: robby.smith commentedabove is the output when using patch at #4 for me
Comment #13
mooffie CreditAttribution: mooffie commentedAmitai, here's a hypothetical question (which is not related to the issue at hand): Would you accept ownership of, say, a "Flag Rules" module, if we decouple the Rules integration from the Flag module itself? I'm not saying we'll decouple it, but it'd be helpful to know if anybody would be interested in maintaining it.
As for the issue at hand:
- Backward compatibility: Will currect saved rules continue to work?
- Simplicity: Will we lose the ability to flag items by simply adding one action?
Comment #14
amitaibuMoffie,
> Would you accept ownership of, say, a "Flag Rules"
I actually haven't used Rules for a long time so I'm less passionate about it, so sorry, but I'd have to refuse. Luckily it's only an hypothetical question ;)
Comment #15
joachim CreditAttribution: joachim commented> I don't use or support Rules in any way, so the only way this will be committed will be if it is tested and reviewed by other users who use Rules.
Heh. Ditto.
Comment #17
akalata CreditAttribution: akalata commentedMarking as postponed, given the need for a Rules-focused maintainer to work with Flag. See #1736524: Rules maintainer / decouple Rules integration to a new project