Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
class DateTimeDefaultWidget extends DateTimeWidgetBase implements ContainerFactoryPluginInterface {
and DateTimeWidgetBase class extends WidgetBase class
class DateTimeWidgetBase extends WidgetBase {
and , WidgetBase class implements ContainerFactoryPluginInterface
abstract class WidgetBase extends PluginSettingsBase implements WidgetInterface, ContainerFactoryPluginInterface {
Proposed resolution
Remove redundant ContainerFactoryPluginInterface from child classes
Comment | File | Size | Author |
---|---|---|---|
#3 | 3155770-3.patch | 6.8 KB | Hardik_Patel_12 |
Comments
Comment #2
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 for Drupal India Association commentedKindly follow a patch.
Comment #3
Hardik_Patel_12 CreditAttribution: Hardik_Patel_12 at QED42 for Drupal India Association commentedComment #4
naresh_bavaskarCode clean up looks good to me.
just tried to find why this code
</code> ModerationOptOutUnpublish.php --> implements ContainerFactoryPluginInterface
was added here. i think after fixing https://www.drupal.org/project/drupal/issues/3051633 this probably cleanup needed.also for this cleanup
DrupalSqlBase.php --> implements ContainerFactoryPluginInterface
this issue https://www.drupal.org/project/drupal/issues/2548977 done that implementsThanks!
Comment #6
catchGood find and nice clean-up.
Committed 49dc61d and pushed to 9.1.x. Thanks!