Discover and fix any D9 compatibility issues.

CommentFileSizeAuthor
#9 interdiff-3138509-5-9.txt1.04 KBmrinalini9
#9 3138509-9.patch1.74 KBmrinalini9
#7 drupal-check-ldap_sso_auth.png30.62 KBridhimaabrol24
#5 interdiff_2-5.txt999 bytesridhimaabrol24
#5 3138509-5.patch1.17 KBridhimaabrol24
#3 3138509-2.patch365 byteskarishmaamin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Kosa Ilma created an issue. See original summary.

karishmaamin’s picture

karishmaamin CreditAttribution: karishmaamin commented

This module has no deprecation code issue. So Add core_version_requirement: ^8 || ^9 to ldap_sso_auth.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687

karishmaamin’s picture

karishmaamin CreditAttribution: karishmaamin commented
Status: Active » Needs review
FileSize
3138509-2.patch365 bytes

This module has no deprecation code issue. So Add core_version_requirement: ^8 || ^9 to ldap_sso_auth.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687

dj1999’s picture

dj1999 CreditAttribution: dj1999 at Brainsum for Tieto commented
Status: Needs review » Needs work

@karishmaamin
It is not true that this module has no deprecation code issue.

 ------ ------------------------------------------------------------------------------------------------------- 
  Line   src/Authentication/Provider/LdapSsoAuthAuthenticationProvider.php                                      
 ------ ------------------------------------------------------------------------------------------------------- 
  63     Parameter $event of method                                                                             
         Drupal\ldap_sso_auth\Authentication\Provider\LdapSsoAuthAuthenticationProvider::handleException() has  
         typehint with deprecated class Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent:        
         since Symfony 4.3, use ExceptionEvent instead                                                          
  64     Call to deprecated method getException() of class                                                      
         Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent:                                       
         since Symfony 4.4, use getThrowable instead                                                            
  66     Call to deprecated method setException() of class                                                      
         Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent:                                       
         since Symfony 4.4, use setThrowable instead                                                            
 ------ -------------------------------------------------------------------------------------------------------

Please fix these before change core version requirement.

ridhimaabrol24’s picture

ridhimaabrol24 CreditAttribution: ridhimaabrol24 at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3138509-5.patch1.17 KB
interdiff_2-5.txt999 bytes

Fixing deprecation errors!

dj1999’s picture

dj1999 CreditAttribution: dj1999 at Brainsum for Tieto commented
Status: Needs review » Needs work

Plese use drupal-check tool to find deprecations.

 ------ ------------------------------------------------------------------------------------------------------- 
  Line   src/Authentication/Provider/LdapSsoAuthAuthenticationProvider.php                                      
 ------ ------------------------------------------------------------------------------------------------------- 
  63     Parameter $event of method                                                                             
         Drupal\ldap_sso_auth\Authentication\Provider\LdapSsoAuthAuthenticationProvider::handleException() has  
         typehint with deprecated class Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent:        
         since Symfony 4.3, use ExceptionEvent instead                                                          
 ------ -------------------------------------------------------------------------------------------------------
ridhimaabrol24’s picture

ridhimaabrol24 CreditAttribution: ridhimaabrol24 at Srijan | A Material+ Company for Drupal India Association commented
FileSize
drupal-check-ldap_sso_auth.png30.62 KB

Hi @dj1999 . I have used drupal check and there were only 2 errors which I have fixed in the patch #5. There were no other deprecations left.
Attaching screenshot here for reference.

dj1999’s picture

dj1999 CreditAttribution: dj1999 at Brainsum for Tieto commented
Version: 8.x-1.0 » 8.x-2.x-dev

@ridhimaabrol24
It is interesting as you see after applied patch I got this deprecated function what I wrote abowe.
I checked on Drupal version 9.1.0-dev and ldap sso auth 2.x-dev branch

$ vendor/bin/drupal-check web/modules/contrib/ldap_sso_auth
⚠️  You're using a deprecated config option bootstrap. ⚠️️

This option has been replaced with bootstrapFiles which accepts a list of files
to execute before the analysis.

 6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------------------------------- 
  Line   src/Authentication/Provider/LdapSsoAuthAuthenticationProvider.php                                      
 ------ ------------------------------------------------------------------------------------------------------- 
  63     Parameter $event of method                                                                             
         Drupal\ldap_sso_auth\Authentication\Provider\LdapSsoAuthAuthenticationProvider::handleException() has  
         typehint with deprecated class Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent:        
         since Symfony 4.3, use ExceptionEvent instead                                                          
 ------ ------------------------------------------------------------------------------------------------------- 

 [ERROR] Found 1 error

Please fix it to ready this issue.

mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3138509-9.patch1.74 KB
interdiff-3138509-5-9.txt1.04 KB

Fixed deprecations as mentioned in #8, please review.

  • dj1999 committed 1d16788 on 8.x-2.x authored by mrinalini9 
    Issue #3138509 by ridhimaabrol24, mrinalini9, karishmaamin: D9 readyness
dj1999’s picture

dj1999 CreditAttribution: dj1999 at Brainsum for Tieto commented
Status: Needs review » Fixed
dj1999’s picture

dj1999 CreditAttribution: dj1999 at Brainsum for Tieto commented
Status: Fixed » Closed (fixed)