Problem/Motivation

We used to need to rebuild the router a lot. Now we should not.

Proposed resolution

Remove unnecessary route rebuilds from tests.

Remaining tasks

User interface changes

N/a

API changes

N/a

Data model changes

N/a

Release notes snippet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
FileSize
55.26 KB

So much unnecessary work!

catch’s picture

Status: Needs review » Reviewed & tested by the community

Nice green patch. https://dispatcher.drupalci.org/job/drupal_patches/52719/ says 58 minute run time, compared to the 59 minutes for the last core test run (as I write this), so might be a minimal improvement for overall test run length but still good to remove all the redundant calls.

alexpott’s picture

Recorded resolution for 'core/modules/taxonomy/tests/src/Functional/Views/TaxonomyFieldFilterTest.php'.

andypost’s picture

+1 to remove useless rebuilds from setup, other places looks called only after setup, so this rebuild useless as well

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed 618f658 and pushed to 9.1.x. Thanks!

  • catch committed ef3190f on 9.1.x
    Issue #3157954 by alexpott, andypost: Remove unnecessary route rebuild...
Wim Leers’s picture

WOAH! Nice work! So much less confusion/dark magic! 👏🙏

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.