Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The Testing profile's override of locale.settings.yml
was never updated for #1998088: Convert locale_translate_english variable to CMI and #2907863: Prefer HTTPS protocol over HTTP when fetching translations.
Proposed resolution
Update the file so that the only override vs. the module-shipped config is import_enabled: false
.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2988960-2.patch | 822 bytes | tstoeckler |
Comments
Comment #2
tstoecklerHere we go.
Comment #5
Kristen PolPatch applies cleanly to 9.1.x.
Comment #6
Kristen PolThanks for the issue and patch.
1) Confirmed that patch changes:
default_server_pattern
so that it's like #2907863: Prefer HTTPS protocol over HTTP when fetching translations
2) Confirmed that patch changes:
translate_english
so it's like #1998088: Convert locale_translate_english variable to CMI
3) Compared
core/profiles/testing/config/optional/locale.settings.yml
andcore/modules/locale/config/install/locale.settings.yml
and the only difference isimport_enabled
:4) Patch covers the issue summary.
5) Kicked off tests for 9.1.x. If those pass, seems RTBC to me.
Comment #7
Kristen PolTests failed for 9.1.x. Back to needs work.
Comment #8
tstoecklerThat was a random failure in line 180 of EntityReferenceWidgetTest::testWidget():
Marking RTBC per #6.5
Comment #9
tstoecklerComment #10
alexpottCommitted and pushed cb2b75344a to 9.1.x and 0ce998a243 to 9.0.x and 5fbd535c71 to 8.9.x. Thanks!
Still true.
Backported to 8.9.x to keep all the test stuff aligned.