Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
$filters = $view->displayHandlers->get('default')->getOption('filters');
$filters['field_date_value']['type'] = 'Date';
On testDateTimeSchema(), the $filters variable is initialized, but never used.
That variable should be used as intended in #2895544: Datetime module missing view plugin config schema.
Comment | File | Size | Author |
---|---|---|---|
#5 | 3157369-5.patch | 832 bytes | Lendude |
#2 | 3157369-2.patch | 726 bytes | shaktik |
Comments
Comment #2
shaktikComment #3
sharma.amitt16 CreditAttribution: sharma.amitt16 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commentedThe patch is removing the unused variable successfully.
Changing the status to RTBC.
Comment #4
alexpottI think this shows that that test is a little bit incomplete. I think this test was trying to show that regardless of whether the config is
or is
the schema is valid.
This was added in #2895544: Datetime module missing view plugin config schema
I think this is meant to be
Comment #5
Lendude@alexpott I agree, that does seem to be the intent. It's green when changed, so it seems better to add that and have coverage for that then taking it out.
Updated the IS.
Comment #6
Krzysztof DomańskiComment #7
alexpottCommitted and pushed 1476de31ad to 9.1.x and 2dc6a5970e to 9.0.x and 1c57be3adf to 8.9.x. Thanks!