• Sync the entire source code in the OpenStack repository from Cloud project
CommentFileSizeAuthor
#4 3159471-4.patch1.03 MByas
#2 3159471-2.patch1.02 MByas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Active » Needs review
FileSize
3159471-2.patch1.02 MB
baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas, Thanks for the patch. It is a big one. I think this looks good because it is a mirror of what we have in cloud module.

I have a concern, what if a user stumbles upon this module and wants to use it? I think we should have some wording on the project page telling them to go to cloud module to download/use it.

What do you think?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
3159471-4.patch1.03 MB

@baldwinlouie

Thank you for your review. I also added/updated README.md in this OpenStack module. I'll merge the patch to 8.x-1.x and close this issue as Fixed.

  • yas committed 8bee278 on 8.x-1.x 
    Issue #3159471 by yas, baldwinlouie: Sync the entire source code in the...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.