Manage K8s Priority Classes

@kumikoono

Thank you for adding the feature. Could you please move the following code? (The position of k8s_update_dependencies() should be always at the bottom of the k8s.install explicitly since it is a specific function for us describing the dependencies, which might be lost somewhere in k8s.install in the future if we put a random position.)

FROM:

+++ b/modules/cloud_service_providers/k8s/k8s.install
@@ -2051,3 +2051,21 @@ function k8s_update_dependencies() {
 
   return $dependencies;
 }
+
+/**
+ * Add entity type k8s_priority_class and view k8s_priority_class.
+ */
+function k8s_update_8288() {
+  // Add entity type k8s_priority_class.
+  $definition_update_manager = \Drupal::entityDefinitionUpdateManager();
+  $entity_type = \Drupal::entityTypeManager()->getDefinition('k8s_priority_class');
+  $definition_update_manager->uninstallEntityType($entity_type);
+  $definition_update_manager->installEntityType($entity_type);
+
+  // Add view k8s_priority_class.
+  $files = [
+    'views.view.k8s_priority_class.yml',
+    'system.action.k8s_priority_class_delete_action.yml',
+  ];
+  \Drupal::service('cloud')->updateYmlDefinitions($files, 'k8s');
+}

TO:

/**
 * Add entity type k8s_priority_class and view k8s_priority_class.
 */
function k8s_update_8288() {
  // Add entity type k8s_priority_class.
  $definition_update_manager = \Drupal::entityDefinitionUpdateManager();
  $entity_type = \Drupal::entityTypeManager()->getDefinition('k8s_priority_class');
  $definition_update_manager->uninstallEntityType($entity_type);
  $definition_update_manager->installEntityType($entity_type);

  // Add view k8s_priority_class.
  $files = [
    'views.view.k8s_priority_class.yml',
    'system.action.k8s_priority_class_delete_action.yml',
  ];
  \Drupal::service('cloud')->updateYmlDefinitions($files, 'k8s');
}

/**
 * Implements hook_update_dependencies().
 */
function k8s_update_dependencies() {
  $dependencies = [];

  $dependencies['k8s'] = [
    8226 => ['cloud' => 8122],
    8273 => ['cloud' => 8128],
    8274 => ['cloud' => 8131],
    8275 => ['cloud' => 8133],
  ];

  return $dependencies;
}

@kumikoono @yas

Thanks for your patch. I confirmed the operations in my local environment, and I found some problems as below.

class K8sBatchOperations {
     $entity_id = $k8s_service->getEntityId(
       'k8s_priority_class',
       'name',
       $name,
      );

"$name," should be "$name".

public function updatePriorityClass(array $params = []) {
    // Remove empty properties.
    $params['value'] = array_filter($params['value']);

The code "$params['value'] = array_filter($params['value']);" should be removed, because the value of $params['value'] is not array, and there is no properties in $params['value']. And after I fixed it, I can update priority class. Please try it.

@kumikoono

Thank you for your follow-up. If possible, could you please put the tab menu as shown below (in between Limit Range and ConfigMaps)?

@kumikoono

Thank you for the update. Could you please the additional columns such as Value, Global Default and Description into the list view?

@kumikoono

Thank you for the update. It looks perfect to me now.

@xiaohua-guan

Could you please review the patch?

@yas

The patch file looks good to me.

@xiaohua-guan

Thank you for your review. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.