Hello,

Thanks a lot for your module, I am very happy to integrate components_block in our ui_patterns wokflow.

Problem/Motivation

https://www.drupal.org/project/component module should not be a dependency of components_block.

Components namespaces are only used with ui_patterns when override patterns behaviour with "use" property, which may not be the general case.

Source: https://ui-patterns.readthedocs.io/en/8.x-1.x/content/patterns-definitio...

For example, in our projects, we don't override with "use" property and components_block works without the components module.

Proposed resolution

Remove:

  • drupal/components from composer.json
  • components:components from component_blocks.info.yml
CommentFileSizeAuthor
#4 3159587-4.patch354 bytesnitesh624
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pdureau created an issue. See original summary.

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
CreditAttribution: nitesh624 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented

working on this

pdureau’s picture

pdureau CreditAttribution: pdureau at Smile commented
Issue summary: View changes
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
CreditAttribution: nitesh624 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3159587-4.patch354 bytes
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
CreditAttribution: nitesh624 as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Active » Needs review

  • larowlan committed 4eca6e8 on 1.0.x authored by nitesh624 
    Issue #3159587 by nitesh624: Remove component module dependency
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Version: 1.0.1 » 1.0.x-dev
Status: Needs review » Fixed

thanks
cutting a 1.0.2 release

pdureau’s picture

pdureau CreditAttribution: pdureau at Smile commented
Status: Fixed » Needs review

Hi Nitesh & Lee,

it seems 3159587-4.patch only remove components:components from component_blocks.info.yml and not drupal/components from composer.json

Is it something missing or a deliberate choice?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Fixed

@pdureau there is no composer.json in this project, its handled by the project_composer facade on Drupal.org

Are you saying you can't update?

  • larowlan committed f4ec407 on 1.0.x 
    Issue #3159587 by larowlan: Reinstate test dependnecy
pdureau’s picture

pdureau CreditAttribution: pdureau at Smile commented

Oh sorry, I didn't know about this d.o project_composer facade behaviour. I add the composer.json myself on my own projects.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

Yeah https://www.drupal.org/project/project_composer powers https://packages.drupal.org/8/packages.json which is read by composer.

project_composer turns .info.yml files into composer.json metadata automagically 🧚‍♀️

If you don't require third-party PHP libraries, it's easier to let it do its thing and opt-out of a project level composer.json

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented

If updating doesn't resolve, please let me know

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.