When using a token to generate a path, the resulting URL contains 'http:/' as with only a single slash. All browsers (other than Safari) interpret this as not containing the domain. So the browsers remove the colon and add the domain redundantly to the front of the URL, thus rendering it unusable.

The issue seems to center in the _custom_breadcrumbs_create_crumb_items() function of this module, which contains a preg_replace() command that removes all double-slashes indiscriminately. See below:
$original_path = preg_replace('/\/+/', '/', $original_path);

A better regular expression would only combine double-slashes that don't follow a colon:
$original_path = preg_replace('/[^:](\/\/+)/', '/', $original_path);

CommentFileSizeAuthor
#1 qualify_double_slashes-2151579-1.patch757 bytestomogden
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tomogden’s picture

See patch attached.

tomogden’s picture

Status: Active » Needs review
bebelg’s picture

Thank you tomogden

It correct one big error on my website

Proteo’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for the fix, I just found the bug and came here to report it. The patch fixes the issue for me, I guess it's time to move it to RTBC?

surfgatinho’s picture

Works for me.
Any chance of getting this committed?

Summit’s picture

Hi, is this patch committed please? Or is this module not maintained anymore? thanks for replying in advance, greetings Martijn

  • lamp5 committed 0849dc2 on 7.x-2.x authored by tomogden
    Issue #2151579 by tomogden: Paths containing 'http://' have the double-...
lamp5’s picture

Status: Reviewed & tested by the community » Fixed

True, commited.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.