There are some coding standard issues in this module.

CommentFileSizeAuthor
#9 2913761-9.patch6.08 KBNeslee Canil Pinto
#4 coding_standard_issues-2913761-4.patch6.08 KBdhruveshdtripathi
#2 addanother_coding_standard-2913761-2.patch9.01 KBjayesh_makwana
addanother.txt4.6 KBjayesh_makwana
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jayesh_makwana created an issue. See original summary.

jayesh_makwana’s picture

jayesh_makwana CreditAttribution: jayesh_makwana at cmsMinds commented
FileSize
addanother_coding_standard-2913761-2.patch9.01 KB

We created a patch for solving coding standard issues for this module. Please check and apply it.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented

This is a duplicate issue please see:


https://www.drupal.org/node/2902348

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Assigned: jayesh_makwana » Unassigned
Status: Active » Needs review
FileSize
coding_standard_issues-2913761-4.patch6.08 KB

Attaching a patch that doesn't cover changes in README file.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Related issues: +#2902348: Reformat README for D8 branch
bleen’s picture

bleen CreditAttribution: bleen at NBCUniversal commented
Status: Needs review » Reviewed & tested by the community

I didnt check the rest of the module for other possible infractions, but everything in this patch is correct

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor at Drupal Ukraine Community, GOLEMS GABB for Drupal Ukraine Community, GOLEMS GABB commented

+1

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Reviewed & tested by the community » Needs work 
FILE: ...rs/neslee/Documents/sites/optimus/web/modules/custom/addanother/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
 14 | WARNING | Line exceeds 80 characters; contains 170 characters
 35 | WARNING | Line exceeds 80 characters; contains 135 characters
 36 | WARNING | Line exceeds 80 characters; contains 131 characters
 37 | WARNING | Line exceeds 80 characters; contains 130 characters
 38 | WARNING | Line exceeds 80 characters; contains 93 characters
 39 | WARNING | Line exceeds 80 characters; contains 177 characters
--------------------------------------------------------------------------------

Time: 145ms; Memory: 10MB
Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs work » Needs review
FileSize
2913761-9.patch6.08 KB

Updated the Readme.txt in #2902348: Reformat README for D8 branch, which where giving these errors. And Updated automated testing version for add another issue queues.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.