Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
For compatibility with D9, add core_version_requirement: ^8 || ^9 to info.yml file.
Comment | File | Size | Author |
---|---|---|---|
#18 | colordialog-d9-support-3135491-18.patch | 1.95 KB | szeidler |
#15 | colordialog_d9_compatibility_3135491_15.patch | 3.89 KB | adinac |
#11 | Screenshot 2020-05-26 at 12.44.13 PM.png | 36.75 KB | kkalashnikov |
#7 | interdiff_3-7.txt | 1.59 KB | ankitsingh0188 |
#7 | 3135491-7.patch | 1.96 KB | ankitsingh0188 |
Comments
Comment #2
sarvjeetsingh CreditAttribution: sarvjeetsingh as a volunteer and at QED42 for Drupal India Association commentedadded
core_version_requirement: ^8 || ^9
to info.yml file.Comment #3
sarvjeetsingh CreditAttribution: sarvjeetsingh as a volunteer and at QED42 for Drupal India Association commentedadded
core_version_requirement: ^8 || ^9
to info.yml file.Comment #4
meghasharma CreditAttribution: meghasharma as a volunteer and at QED42 for Drupal India Association commentedplease provide the screenshots of rector and drupal_check command..
Comment #5
meghasharma CreditAttribution: meghasharma as a volunteer and at QED42 for Drupal India Association commentedits giving error while run the drupal_check command
please fix these errors..
drupal-8.8.1 % vendor/bin/drupal-check -ad modules/contrib/colordialog
Warning: Class 'PHPUnit\Framework\MockObject\Matcher\InvokedRecorder' not found in /Users/Documents/standar_drupal/drupal-8.8.1/core/tests/bootstrap.php on line 197
2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ----------------------------------------
Line colordialog.install
------ ----------------------------------------
16 Function libraries_get_path not found.
------ ----------------------------------------
------ -------------------------------------------
Line src/Plugin/CKEditorPlugin/ColorDialog.php
------ -------------------------------------------
25 Function libraries_get_path not found.
------ -------------------------------------------
[ERROR] Found 2 errors
Comment #6
ankitsingh0188Comment #7
ankitsingh0188Created the patch and make it compatible with D9.
Comment #8
priyanka.sahni CreditAttribution: priyanka.sahni at Srijan | A Material+ Company for Drupal India Association commentedComment #9
priyanka.sahni CreditAttribution: priyanka.sahni at Srijan | A Material+ Company for Drupal India Association commentedComment #10
kkalashnikov CreditAttribution: kkalashnikov at Srijan | A Material+ Company for Drupal India Association commentedComment #11
kkalashnikov CreditAttribution: kkalashnikov at Srijan | A Material+ Company for Drupal India Association commentedThis module is compatible with Drupal version 9.
Test with the drupal-check utility and found 0 errors. For me it's RTBC.
Comment #12
Ravi_3596 CreditAttribution: Ravi_3596 at TATA Consultancy Services for Pfizer, Inc. commentedThe patch #7 works fine for me. It would be better if we merge patch in dev branch to make module compatible with D9.
Comment #13
Ravi_3596 CreditAttribution: Ravi_3596 at TATA Consultancy Services for Pfizer, Inc. commentedComment #14
GGH CreditAttribution: GGH commentedWhen can we expect a stable release for this module ported for Drupal 9,Can we have some timelines
Comment #15
adinac CreditAttribution: adinac as a volunteer commentedComment #16
WebbehPer #15, can you please provide context for the patch, and how this differs from the work in #7?
Comment #17
szeidler CreditAttribution: szeidler at Ramsalt Lab commentedWouldn't it be better to drop the libraries dependencies and use the new core service for it? See https://www.drupal.org/node/3099614
Comment #18
szeidler CreditAttribution: szeidler at Ramsalt Lab commentedHere would be an example, without using the libraries module at all.
Comment #20
g_miric CreditAttribution: g_miric at FFW, Develomon commentedComment #21
g_miric CreditAttribution: g_miric at FFW, Develomon commented