When a view is configured to group by a field value while using the `Display Suite: Paragraph` show format and the grouping field is not a required field on the paragraph entity, an empty heading tag is still rendered when that field is left empty on the entity. Patch included does a simple check to see if there is a value to render prior to adding the h2 render markup.

CommentFileSizeAuthor
ds-empty-grouping-title-1.patch645 bytessherakama
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sherakama created an issue. See original summary.

swentel’s picture

Status: Active » Needs review

Should be fine for the bot I think - not sure if we have a test for it, but the code makes sense.

  • swentel committed d7418ab on 8.x-4.x authored by sherakama
    Issue #3154727 by sherakama: Empty Grouping Title Heading
    

  • swentel committed 982a44b on 8.x-3.x authored by sherakama
    Issue #3154727 by sherakama: Empty Grouping Title Heading
    
swentel’s picture

Status: Needs review » Fixed

committed and pushed, thanks!

swentel’s picture

Status: Fixed » Closed (fixed)
sherakama’s picture

Awesome. Thanks for punching the release too!