CommentFileSizeAuthor
#8 interdiff-3165254-8.txt34.27 KBjigish.addweb
#8 3165254-8.patch76.27 KBjigish.addweb
#3 3165254-3.patch76.09 KBjigish.addweb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
Issue summary: View changes
jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
FileSize
3165254-3.patch76.09 KB
jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@jigishaddweb

Thank you for adding test cases. This is a great patch.

  1. Please use a single quote ('):
    +++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/ElasticIpTest.php
@@ -558,4 +559,149 @@ class ElasticIpTest extends AwsCloudTestBase {
+    $this->drupalGet("/clouds/aws_cloud/elastic_ip");
...
+    $this->drupalGet("/clouds/aws_cloud/elastic_ip");
...
+    $this->drupalGet("/clouds/aws_cloud/elastic_ip");
...
+    $this->drupalGet("/clouds/aws_cloud/elastic_ip");

+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/ImageTest.php
@@ -447,6 +448,148 @@ class ImageTest extends AwsCloudTestBase {
+    $this->drupalGet("/clouds/aws_cloud/image");
...
+    $this->drupalGet("/clouds/aws_cloud/image");
...
+    $this->drupalGet("/clouds/aws_cloud/image");

+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/InstanceTest.php
@@ -645,12 +647,169 @@ class InstanceTest extends AwsCloudTestBase {
+    $this->drupalGet("/clouds/aws_cloud/instance");
...
+    $this->drupalGet("/clouds/aws_cloud/instance");

+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/KeyPairTest.php
@@ -233,4 +234,134 @@ class KeyPairTest extends AwsCloudTestBase {
+    $this->drupalGet("/clouds/aws_cloud/key_pair");
...
+    $this->drupalGet("/clouds/aws_cloud/key_pair");
...
+    $this->drupalGet("/clouds/aws_cloud/key_pair");
...
+    $this->drupalGet("/clouds/aws_cloud/key_pair");

+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/NetworkInterfaceTest.php
@@ -342,4 +343,134 @@ class NetworkInterfaceTest extends AwsCloudTestBase {
+    $this->drupalGet("/clouds/aws_cloud/network_interface");
...
+    $this->drupalGet("/clouds/aws_cloud/network_interface");
...
+    $this->drupalGet("/clouds/aws_cloud/network_interface");
...
+    $this->drupalGet("/clouds/aws_cloud/network_interface");

+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/SecurityGroupTest.php
@@ -332,6 +333,112 @@ class SecurityGroupTest extends AwsCloudTestBase {
+    $this->drupalGet("/clouds/aws_cloud/security_group");
...
+    $this->drupalGet("/clouds/aws_cloud/security_group");
...
+    $this->drupalGet("/clouds/aws_cloud/security_group");

+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/SnapshotTest.php
@@ -368,6 +369,145 @@ class SnapshotTest extends AwsCloudTestBase {
+    $this->drupalGet("/clouds/aws_cloud/snapshot");
...
+    $this->drupalGet("/clouds/aws_cloud/snapshot");
...
+        // Click "Create Volume" link.
...
+    $this->drupalGet("/clouds/aws_cloud/snapshot");
...
+    $this->drupalGet("/clouds/aws_cloud/snapshot");

+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Ec2/VolumeTest.php
@@ -354,6 +355,147 @@ class VolumeTest extends AwsCloudTestBase {
+    $this->drupalGet("/clouds/aws_cloud/volume");
...
+    $this->drupalGet("/clouds/aws_cloud/volume");
...
+    $this->drupalGet("/clouds/aws_cloud/volume");
...
+    $this->drupalGet("/clouds/aws_cloud/volume");

+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Vpc/SubnetTest.php
@@ -197,6 +198,144 @@ class SubnetTest extends AwsCloudTestBase {
+    $this->drupalGet("/clouds/aws_cloud/subnet");
...
+    $this->drupalGet("/clouds/aws_cloud/subnet");
...
+    $this->drupalGet("/clouds/aws_cloud/subnet");

+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Vpc/VpcPeeringConnectionTest.php
@@ -209,6 +210,143 @@ class VpcPeeringConnectionTest extends AwsCloudTestBase {
+    $this->drupalGet("/clouds/aws_cloud/vpc_peering_connection");
...
+    $this->drupalGet("/clouds/aws_cloud/vpc_peering_connection");
...
+    $this->drupalGet("/clouds/aws_cloud/vpc_peering_connection");
...
+    $this->drupalGet("/clouds/aws_cloud/vpc_peering_connection");

+++ b/modules/cloud_service_providers/aws_cloud/tests/src/Functional/Vpc/VpcTest.php
@@ -194,6 +195,139 @@ class VpcTest extends AwsCloudTestBase {
+    $this->drupalGet("/clouds/aws_cloud/vpc");
...
+    $this->drupalGet("/clouds/aws_cloud/vpc");
...
+    $this->drupalGet("/clouds/aws_cloud/vpc");
...
+    $this->drupalGet("/clouds/aws_cloud/vpc");
  2. Also, please use a ${variable} style in a literal in the entire code.
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Related issues: +#3165254: Add test cases for Refresh buttons of All listing view in each AWS resource
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Related issues: +#3164269: Refactor the Refresh logic in All listing view in each OpenStack resource, +#3162125: Add a Refresh button in All listing view in each K8s resource

@jigishaddweb

We need to check at:

jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs work » Needs review
FileSize
3165254-8.patch76.27 KB
interdiff-3165254-8.txt34.27 KB

@yas

Refresh button is not displaying with AND condition like edit any aws cloud instance+edit own aws cloud instance,view all cloud service providers so I changed it with OR (i.e. edit any aws cloud instance+edit own aws cloud instance+view all cloud service providers) with this condition, Refresh button is displaying and Testcase is passed successfully.

Please let me know your thoughts about this.

I have uploaded updated patch. Please review.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@jigishaddweb

I talked w/ @liuchanggang --- He double-checked the code and aligned the permission as you suggested (concatenating _OR_ (+)). I'll merge the patch to 8.x-1.x, 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed c3bb549 on 8.x-1.x authored by jigish.addweb 
    Issue #3165254 by jigish.addweb, yas: Add test cases for Refresh buttons...

  • yas committed c8a75e3 on 8.x-2.x authored by jigish.addweb 
    Issue #3165254 by jigish.addweb, yas: Add test cases for Refresh buttons...

  • yas committed dc79643 on 3.x authored by jigish.addweb 
    Issue #3165254 by jigish.addweb, yas: Add test cases for Refresh buttons...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed
Related issues: -#3165254: Add test cases for Refresh buttons of All listing view in each AWS resource

  • yas committed 46cba4e on 8.x-1.x authored by jigish.addweb 
    Issue #3165254 by jigish.addweb, yas: Add test cases for Refresh buttons...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.