Problem/Motivation

The logo in the toolbar links hardcoded to /
This is an issue if you have a multilingual site, or your drupal webroot is not on /

Proposed resolution

Change the link in twig to {{ url('') }}

CommentFileSizeAuthor
#2 3165373-2-logo_link_language.patch1.32 KBbetz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

betz created an issue. See original summary.

betz’s picture

betz CreditAttribution: betz commented
FileSize
3165373-2-logo_link_language.patch1.32 KB

  • saschaeggi committed 66888b3 on 8.x-3.x authored by betz 
    Issue #3165373 by betz: Link logo in toolbar to <front> instead of /
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented
Status: Active » Fixed

Thanks betz this is a great fix, haven't thought about it! :)

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented
Assigned: betz » Unassigned
gaards’s picture

gaards CreditAttribution: gaards as a volunteer and at Yle - Finnish Broadcasting Company for Yle - Finnish Broadcasting Company commented

The menu template in Gin Toolbar needs these changes as well, as now the link would work correctly in the backend but not in the frontend.

Is there a reason why the link wasn't changed for the following line as well? https://git.drupalcode.org/project/gin/-/blob/8.x-3.x/templates/navigati...

betz’s picture

betz CreditAttribution: betz commented

ah, no, i forgot that one.
As my icon is updated, everything worked for me.
you make the patch?

  • saschaeggi committed 1f7d25d on 8.x-3.x authored by betz 
    Issue #3165373 by betz, saschaeggi: Link logo in toolbar to <front>...
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented

Seems like the patch did miss the third one and I didn't check tbh. It's now in, thanks for letting me know! :)
Also it's updated on Toolbar as well.

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented

Updated Credit to include gaards

betz’s picture

betz CreditAttribution: betz commented

❤️

thanks for the theme by the way, awesome admin theme!

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented

Glad you like it betz 🙃

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented
Status: Fixed » Closed (fixed)

included in alpha26 release