FILE: /var/www/html/drupal-contrib/modules/contrib/ezcontent_api/modules/ezcontent_preview/src/Form/PreviewForm.php
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
68 | WARNING | NodeType::loadMultiple calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal-contrib/modules/contrib/ezcontent_api/modules/ezcontent_preview/src/Controller/PreviewView.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------
24 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
62 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
63 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
64 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#7 ezcontent_api-3128797-7.patch4.74 KBkarishmaamin
#5 3128797-3.patch3.35 KBprabha1997
#3 3128797-2.patch2.75 KBprabha1997
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kuldeep_mehra27 created an issue. See original summary.

prabha1997’s picture

prabha1997 CreditAttribution: prabha1997 at Valuebound for Valuebound commented
Assigned: Unassigned » prabha1997
Status: Active » Needs work
prabha1997’s picture

prabha1997 CreditAttribution: prabha1997 at Valuebound for Valuebound commented
Assigned: prabha1997 » Unassigned
Status: Needs work » Needs review
FileSize
3128797-2.patch2.75 KB

Kindly review patch

prabha1997’s picture

prabha1997 CreditAttribution: prabha1997 at Valuebound for Valuebound commented
Assigned: Unassigned » prabha1997
Issue summary: View changes
Status: Needs review » Needs work
prabha1997’s picture

prabha1997 CreditAttribution: prabha1997 at Valuebound for Valuebound commented
Assigned: prabha1997 » Unassigned
Status: Needs work » Needs review
FileSize
3128797-3.patch3.35 KB

Kindly review my patch

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom at build2be commented
Status: Needs review » Needs work

Some doc comment have too many spaces.

+    /** <==========================
+   * Entity type manager.
....
+    /** <==========================
+   * Route match.
....
+   /** <==========================
+   * Create container create.
+   */
karishmaamin’s picture

karishmaamin CreditAttribution: karishmaamin commented
Status: Needs work » Needs review
FileSize
ezcontent_api-3128797-7.patch4.74 KB

please review

saurabh-2k17’s picture

saurabh-2k17 CreditAttribution: saurabh-2k17 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » saurabh-2k17

Hi,

We have resolved all dependency injection and D9 compatibility issues.

Thank you

saurabh-2k17’s picture

saurabh-2k17 CreditAttribution: saurabh-2k17 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: saurabh-2k17 » Unassigned
Status: Needs review » Fixed
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom at build2be commented
Status: Fixed » Needs review

@Saurabh_sgh not sure what your intention was but it was not helping ... "We have resolved ..." without a commit does not help.

This still needs a review.

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
CreditAttribution: vaibhavjain at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs review » Fixed

Hi @clemens.tolboom Sorry we missed this issue in the issue queue. Internally, we were working on making this compatible with D9 and sort out any PHPCS issues. Please see the commit history here https://git.drupalcode.org/project/ezcontent_api/-/commits/8.x
If you have any feedback / issues / feature requests, please open a new issue.
I am adding credits to you on the issue #3128795: Drupal 9 Readiness

Keep Contributing !!

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
CreditAttribution: vaibhavjain at Srijan | A Material+ Company for Drupal India Association commented
Status: Fixed » Closed (fixed)