We have our site behind a separate edit subdomain so when the plugin looks at the url, it has no idea it's in the system. For instance, our authors edit on edit.domain.com but the site that SiteImprove sees is www.domain.com. Would it be possible to allow for that somehow? We may take a stab at a patch for this, but if it's easy for you all, that'd be great too.

Comments

johnnykrisma created an issue. See original summary.

Twan Meijerink’s picture

Twan Meijerink CreditAttribution: Twan Meijerink at SIM commented

Same problem here (we have a decoupled CMS). A fix would be great.

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte at FFW commented
Assigned: Unassigned » bartvig

  • bartvig committed 28d3d96 on 8.x-1.x 
    Issue #3030125 by johnnykrisma: Implement plugin manager for handling...
bartvig’s picture

bartvig CreditAttribution: bartvig commented
Version: 8.x-1.x-dev » 8.x-1.2
Status: Active » Fixed
bartvig’s picture

bartvig CreditAttribution: bartvig commented
Version: 8.x-1.2 » 8.x-1.1
bartvig’s picture

bartvig CreditAttribution: bartvig commented
Status: Fixed » Closed (fixed)
brockfanning’s picture

brockfanning CreditAttribution: brockfanning commented

What it be possible to backport this feature to the D7 version?

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte at FFW commented
Assigned: bartvig » beltofte
Status: Closed (fixed) » Active

Hi @brockfanning,

Which specific features do you need in D7? Just a separate frontend URL or the Domain Access integration?

We are not adding new features to the D7 version, but I will discuss it with my contacts at Siteimprove and see if they approve downgrading the new feature - fully or partly.

Best regards,
Jens

brockfanning’s picture

brockfanning CreditAttribution: brockfanning commented
Assigned: beltofte » Unassigned

Thanks for the quick reply! In our case, only the separate frontend URL is needed.

brockfanning’s picture

brockfanning CreditAttribution: brockfanning commented

@beltofte Sorry, not sure why it unassigned you.

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte at FFW commented

@brockfanning: Thanks for your reply! Your use case is the simplest to implement - considering if we should implement it using Ctools plugins to make it flexible. We will discuss it with Siteimprove next week and get back to you!

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte at FFW commented
Assigned: Unassigned » beltofte
beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte at FFW commented

@brockfanning A short update after a call with Siteimprove. We have agreed to implement this functionality in the D7 version. I expect to have the functionality in a dev release within a week or two.

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte at FFW commented
Version: 8.x-1.1 » 7.x-1.x-dev

  • beltofte committed 67b577f on 7.x-1.x 
    Issue #3030125 by beltofte: Allow for different edit and public URLs
beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte at FFW commented
Status: Active » Fixed

It is now possible in the Drupal 7 version to configure a separate frontend domain in the Siteimprove settings form. It is possible to rewrite the frontend domain in custom code using hook_siteimprove_frontend_url_alter(&$rewritten_url, $original_url).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Twan Meijerink’s picture

Twan Meijerink CreditAttribution: Twan Meijerink at SIM commented

Can the fix also be developed for Drupal 8/9?

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
CreditAttribution: beltofte at FFW commented

@twan-meijerink: the support for a different frontend domain already exist in the Drupal 8/9 version. See the brand new documentation. If you need to alter the domain / URL then is our recommendation that you create a custom Siteimprove Domain plugin.