CommentFileSizeAuthor
#7 dii-cloud.dcml_.docomolabs-usa.com_8888_clouds_vmware_vm (2).png304.32 KByas
#5 3168501-5.patch25.5 KBXiaohua Guan
#4 dii-cloud.dcml_.docomolabs-usa.com_8888_clouds_vmware_vm (1).png355.19 KByas
#4 dii-cloud.dcml_.docomolabs-usa.com_8888_clouds_vmware_vm.png320.69 KByas
#3 3168501-3.patch25.44 KBXiaohua Guan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Issue summary: View changes
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Active » Needs review
FileSize
3168501-3.patch25.44 KB

@yas

Please review the patch file. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work
FileSize
dii-cloud.dcml_.docomolabs-usa.com_8888_clouds_vmware_vm.png320.69 KB
dii-cloud.dcml_.docomolabs-usa.com_8888_clouds_vmware_vm (1).png355.19 KB

@xiaohua-guan

Thank for adding the feature. I tested the patch and it looks good to me.

29.png

I have one thing that I want you to change, could you please make Cloud Service Provider ID as the default sort (ascending)?

vmware_vm.png

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3168501-5.patch25.5 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Needs work » Needs review

@yas

Thanks for your comment. Please review the new patch file. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community
FileSize
dii-cloud.dcml_.docomolabs-usa.com_8888_clouds_vmware_vm (2).png304.32 KB

@xiaohua-guan

Thank you for the update. I rebuild my testing environment from scratch and tested the patch and it looks good to me now. I'll merge the patch to 3.x and close this issue as Fixed.

29.png

  • yas committed 3768c11 on 3.x authored by Xiaohua Guan 
    Issue #3168501 by Xiaohua Guan, yas: Add All listing views in each...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.