CommentFileSizeAuthor
#11 3168711-11-diff.txt2.63 KBXiaohua Guan
#11 3168711-11.patch11.35 KBXiaohua Guan
#8 3168711-8.patch10.07 KBXiaohua Guan
#7 dii-cloud.dcml_.docomolabs-usa.com_8888_clouds_vmware_dii_vm_5.png219.63 KByas
#7 dii-cloud.dcml_.docomolabs-usa.com_8888_clouds_vmware_dii_vm_add.png289.58 KByas
#6 3168711-6.patch9.7 KBXiaohua Guan
#3 3168711-3.patch8.49 KBXiaohua Guan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Issue summary: View changes
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3168711-3.patch8.49 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Active » Needs review

@yas

Please review the patch file. Thanks.

Status: Needs review » Needs work

The last submitted patch, 3: 3168711-3.patch, failed testing. View results

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Needs work » Needs review
FileSize
3168711-6.patch9.7 KB

@yas

I've fixed the test case. Please check the new patch. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work
FileSize
dii-cloud.dcml_.docomolabs-usa.com_8888_clouds_vmware_dii_vm_add.png289.58 KB
dii-cloud.dcml_.docomolabs-usa.com_8888_clouds_vmware_dii_vm_5.png219.63 KB

@xiaohua-guan

Thank you for the update. I tested the patch and it looks good to me now. I have one cosmetic request, could you please add one space in between Size and (...)? (e.g. Size (MiB) / Size (GiB))

add.png

5.png

Also, I have a question --- how is the default disk size handled? When I put a black, the system put 16 GiB. Is that a system default disk size value?

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3168711-8.patch10.07 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Needs work » Needs review

@yas

Thanks for your comment.

> could you please add one space in between Size and (...)? (e.g. Size (MiB) / Size (GiB))

Yes, I've fixed it.

> how is the default disk size handled? When I put a black, the system put 16 GiB. Is that a system default disk size value?

I checked the document, but I can't find the default size. But it seems that the default size is 16GB.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the update and the explanation. Could you please make the cosmetic changes in the following code, too? This can be another issue but can you include those fixes into this patch?

  • ./modules/cloud_service_providers/vmware/vmware.install:220: ->setLabel(t('Disk Size(GiB)'))
  • ./modules/cloud_service_providers/vmware/src/Form/VmwareVmCreateForm.php:104: '#title' => $this->t('Memory Size(MiB)'),
  • ./modules/cloud_service_providers/vmware/config/install/views.view.vmware_vm.yml:467: label: 'Memory Size(MiB)'
  • ./modules/cloud_service_providers/vmware/config/install/views.view.vmware_vm.yml:1059: label: 'Memory Size(MiB)'
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
FileSize
3168711-11.patch11.35 KB
3168711-11-diff.txt2.63 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented
Status: Needs work » Needs review

@yas

I fixed those codes too. Please check the new patch. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. I tested the patch and this is perfect. I'll merge the patch to 3.x and close this issue as Fixed.

Only local images are allowed.

Only local images are allowed.

Only local images are allowed.

  • yas committed 29e0af8 on 3.x authored by Xiaohua Guan 
    Issue #3168711 by Xiaohua Guan, yas: Configure the size of hard disk of...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.