Hello,

Having to configure permissions on a website using the group module, I will upload a patch that allows to use speedboxed on the group permissions page.

CommentFileSizeAuthor
#2 speedboxes-group_integration-3039124-2.patch1.22 KBGrimreaper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Grimreaper created an issue. See original summary.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Assigned: Grimreaper » Unassigned
Status: Active » Needs review
FileSize
speedboxes-group_integration-3039124-2.patch1.22 KB

Here is the patch.

Thanks for the review.

frob’s picture

frob
Primary language English
CreditAttribution: frob at Clarity Innovations, Inc. commented

I am sorry, I didn't get any notifications about this.

Patch looks good I will test it and accept it if it works. I would prefer to fit this with the D8 conditions api instead of these à la carte solutions but with one request in five years I don't think the population is clamoring for the ability to put this functionality on any page.

frob’s picture

frob
Primary language English
CreditAttribution: frob at Clarity Innovations, Inc. commented
Assigned: Unassigned » frob
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented

Hello,

@frob, so, it is ok for you to commit this patch?

What do you mean by "the D8 conditions api"? The conditions to place blocks?

frob’s picture

frob
Primary language English
CreditAttribution: frob at Clarity Innovations, Inc. commented

Conditions are used for more than to place blocks. The conditions api is used for pathauto and in other places too.

I don't have a groups D8 site to test this with but it works exactly like the current set for the permissions page so if you say it works then commit it.

  • Grimreaper committed 6ff8516 on 8.x-1.x 
    Issue #3039124 by Grimreaper, frob: Group integration
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Version: 8.x-1.1 » 8.x-1.x-dev
Assigned: frob » Unassigned
Status: Needs review » Fixed

Thanks for your reply.

Ok, agreed that it is used for more than that. But I don't see how it can be used here, and as the code is simple, I don't think it will be worth it. Also in Pathauto I don't see where it is used.

I have retested with the last version of Group, and it is still working.

So merging!

frob’s picture

frob
Primary language English
CreditAttribution: frob at Clarity Innovations, Inc. commented

In pathauto the bit that allows a user to select the bundle is the conditions api.

https://www.drupal.org/project/pathauto/issues/3077491

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented

Thanks @frob for the issue link :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.