Problem/Motivation

Since the work done in #3162586: ​JavascriptTestBase is deprecated and removed from Drupal 9 to make the tests Drupal 9 compatible, the automated tests no longer pass.

Proposed resolution

Since the work on that issue changed the underlying Javascript test base, likely the needed fix is to update the test itself.

CommentFileSizeAuthor
#3 ckeditor_accessibility_auditor-automated_tests-3174808-3.patch1.05 KBmandclu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mandclu created an issue. See original summary.

mandclu’s picture

mandclu CreditAttribution: mandclu at Northern Commerce commented

Based on my understanding, the error is thrown because the test on line 152 of HTMLCodeSnifferTest.php tries to change a value for a form field that is disabled by design.

WebDriverTetBase must handle this scenario differently than JavascriptTestBase did. It would be easy enough to remove this particular test, but it would be good to validate that users without the "administer site configuration" permission are unable to change this value. Any thoughts on how the test might be rewritten?

Or perhaps, this could be addressed by not even displaying the field for users without the permission, and then the test could verify that the field is not in the page for the $not_an_admin user.

mandclu’s picture

mandclu CreditAttribution: mandclu at Northern Commerce commented
Status: Active » Needs review
FileSize
ckeditor_accessibility_auditor-automated_tests-3174808-3.patch1.05 KB

First attempt at an updated test. This verifies that the field is disabled, instead of attempting to submit a bogus value.

  • mandclu committed 8eb13b4 on 8.x-1.x 
    Issue #3174808 by mandclu: Automated test failures
mandclu’s picture

mandclu CreditAttribution: mandclu at Northern Commerce commented
Status: Needs review » Fixed

Updated test seems to pass now, so marking this as fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.