Problem/Motivation

Some css from Claro theme is overriding Gin's background in .ui-dialog.

Steps to reproduce

If you edit a field e.g. a webform field and in the edit dialog on the right the background will be set to none.
Screenshot

Proposed resolution

Adding the snippet in styles/components/_dialog.scss:

Screenshot

Displaying correctly after css changes:

Screenshot

Remaining tasks

If that's a valid issue, create a patch.

CommentFileSizeAuthor
#7 3175286-7_claro-property-overriding-gin-off-canvas.patch446.05 KBsaschaeggi
#6 3175286-claro-property-overriding-gin-off-canvas.patch444.09 KBgwvoigt
Screen Shot 2020-10-06 at 1.28.56 PM.png229.37 KBgwvoigt
Screen Shot 2020-10-06 at 1.26.02 PM.png27.14 KBgwvoigt
Screen Shot 2020-10-06 at 1.06.17 PM.png246.34 KBgwvoigt
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gwvoigt created an issue. See original summary.

gwvoigt’s picture

gwvoigt
Location London, ON 🇨🇦
CreditAttribution: gwvoigt at Northern Commerce commented
Issue summary: View changes
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented
Status: Active » Needs work

@gwvoigt sure please create a patch so I can test it :)

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi at Unic commented
Title: Claro backgroud property is overriding Gin's ui-dialog background color » Claro property is overriding Gin's off-canvas dialog background-color
gwvoigt’s picture

gwvoigt
Location London, ON 🇨🇦
CreditAttribution: gwvoigt at Northern Commerce commented

@saschaeggi to patch scss files, do I patch only the src file or the compiled dist files as well?

gwvoigt’s picture

gwvoigt
Location London, ON 🇨🇦
CreditAttribution: gwvoigt at Northern Commerce commented
FileSize
3175286-claro-property-overriding-gin-off-canvas.patch444.09 KB

Made a patch for it: 3175286-claro-property-overriding-gin-off-canvas.patch

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and commented
Status: Needs work » Needs review
FileSize
3175286-7_claro-property-overriding-gin-off-canvas.patch446.05 KB

As the provided patch will affect all off-canvas dialogs and therefore all those won't work the right way, I've re-rolled the patch to only target the webform UI off-canvas.
Please review.

gwvoigt’s picture

gwvoigt
Location London, ON 🇨🇦
CreditAttribution: gwvoigt at Northern Commerce commented

#7 works for the scss file but fails for the css files

saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and commented

@gwvoigt you'll need to patch it against the latest dev.

gwvoigt’s picture

gwvoigt
Location London, ON 🇨🇦
CreditAttribution: gwvoigt at Northern Commerce commented

Sorry about that. Patched latest dev and works great now.

  • saschaeggi committed 09df5b8 on 8.x-3.x 
    Issue #3175286 by gwvoigt, saschaeggi: Claro property is overriding Gin'...
saschaeggi’s picture

saschaeggi
he/him
CreditAttribution: saschaeggi as a volunteer and commented
Status: Needs review » Fixed

Commited, thanks for reporting

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.