Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Some css from Claro theme is overriding Gin's background in .ui-dialog.
Steps to reproduce
If you edit a field e.g. a webform field and in the edit dialog on the right the background will be set to none.
Proposed resolution
Adding the snippet in styles/components/_dialog.scss:
Displaying correctly after css changes:
Remaining tasks
If that's a valid issue, create a patch.
Comment | File | Size | Author |
---|---|---|---|
#7 | 3175286-7_claro-property-overriding-gin-off-canvas.patch | 446.05 KB | saschaeggi |
| |||
#6 | 3175286-claro-property-overriding-gin-off-canvas.patch | 444.09 KB | gwvoigt |
Screen Shot 2020-10-06 at 1.28.56 PM.png | 229.37 KB | gwvoigt | |
Screen Shot 2020-10-06 at 1.26.02 PM.png | 27.14 KB | gwvoigt | |
Screen Shot 2020-10-06 at 1.06.17 PM.png | 246.34 KB | gwvoigt |
Comments
Comment #2
gwvoigtComment #3
saschaeggi@gwvoigt sure please create a patch so I can test it :)
Comment #4
saschaeggiComment #5
gwvoigt@saschaeggi to patch scss files, do I patch only the src file or the compiled dist files as well?
Comment #6
gwvoigtMade a patch for it: 3175286-claro-property-overriding-gin-off-canvas.patch
Comment #7
saschaeggiAs the provided patch will affect all off-canvas dialogs and therefore all those won't work the right way, I've re-rolled the patch to only target the webform UI off-canvas.
Please review.
Comment #8
gwvoigt#7 works for the scss file but fails for the css files
Comment #9
saschaeggi@gwvoigt you'll need to patch it against the latest dev.
Comment #10
gwvoigtSorry about that. Patched latest dev and works great now.
Comment #12
saschaeggiCommited, thanks for reporting