Problem/Motivation

There's an error in the check of the disabled eu_cookie_compliance_js_alter.

It says (strpos(!empty($parts[2]) && $parts[2], '//') but it should have been (!empty($parts[2]) && strpos($parts[2], '//') === 0)

CommentFileSizeAuthor
#3 eu_cookie_compliance-small-bug-in-disable-script-feature-3175032-3.patch584 bytessvenryen
#2 eu_cookie_compliance-small-bug-in-disable-script-feature-3175032-2.patch1.12 KBsvenryen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

svenryen created an issue. See original summary.

svenryen’s picture

svenryen CreditAttribution: svenryen at Ramsalt Lab commented
Assigned: Unassigned » Neslee Canil Pinto
Status: Active » Needs review
FileSize
eu_cookie_compliance-small-bug-in-disable-script-feature-3175032-2.patch1.12 KB

Here's a patch to resolve the issue.

Steps for testing:
1. Install a module that provides an external script, such as "sharethis"
2. Create a category called "cat"
3. Enter the following in the Disable scripts field:

https://ws.sharethis.com/button/async-buttons.js
http://w.sharethis.com/button/buttons.js

4. Verify that the sharethis buttons are suppressed till you accept cookies.

svenryen’s picture

svenryen CreditAttribution: svenryen at Ramsalt Lab commented
FileSize
eu_cookie_compliance-small-bug-in-disable-script-feature-3175032-3.patch584 bytes

I generated the wrong patch. Here's the right one :)

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs review » Fixed
Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Assigned: Neslee Canil Pinto » Unassigned

  • svenryen committed 062e4fb on 7.x-2.x 
    Merge branch '7.x-1.x' into 7.x-2.x

* 7.x-1.x:
  Issue #3175031 by...
  • Neslee Canil Pinto committed fd7af8a on 7.x-2.x authored by svenryen
    Issue #3175032 by svenryen: [7.x] Small bug in disable script feature

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.