Problem/Motivation

Instead of guarding behind the 'submit simplytest requests' permission, just set routes to access: 'TRUE'

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 3190459-8.patch3.79 KBaritrika.d
#5 3190459-5.patch4.09 KBaritrika.d
#2 3190459-2.patch3.27 KBPooja Ganjage

Issue fork simplytest-3190459

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman created an issue. See original summary.

Pooja Ganjage’s picture

Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commented
FileSize
3190459-2.patch3.27 KB

Hi,

Creating a patch for this issue.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commented
Status: Active » Needs review
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Bluehorn Digital commented
Status: Needs review » Needs work

Could you also remove the permission.yml which defines the permission, please?

aritrika.d’s picture

aritrika.d CreditAttribution: aritrika.d at OpenSense Labs commented
FileSize
3190459-5.patch4.09 KB

Please review the patch

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs work » Needs review
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Bluehorn Digital commented
Status: Needs review » Needs work 
+++ /dev/null
@@ -1,6 +0,0 @@
-administer simplytest projects:
-  title: 'Administer SimplyTest Projects'
-  restrict access: true

Okay, it provides two permissions. Let's not delete it. Only the relevant permission.

aritrika.d’s picture

aritrika.d CreditAttribution: aritrika.d at OpenSense Labs commented
FileSize
3190459-8.patch3.79 KB
Pooja Ganjage’s picture

Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commented
Status: Needs work » Needs review
mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Bluehorn Digital commented
Status: Needs review » Needs work

Does not apply, needs re-roll – creating issue fork with the reroll.

mglaman opened merge request !20

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Bluehorn Digital commented
Status: Needs work » Reviewed & tested by the community

The patch is rerolled on the MR and ready to go

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
CreditAttribution: nerdstein as a volunteer and commented
Status: Reviewed & tested by the community » Fixed

Fixed - thank you all

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.