Problem/Motivation

Changing the discount percentage on a variation or group requires clearing the caches for price resolver to reflect the changes.

Proposed resolution

Fix it

Issue fork commerce_vado-3191998

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TonyTheFerg created an issue. See original summary.

ericchew made their first commit to this issue’s fork.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Bluehorn Digital commented

What needs to be done:

Pseudo code ahoy:

* hook_commerce_product_view to append cache data
* get all referenced groups ->get($field_name)->referencedEntities()
* foreach $refererenced_entity => $reference_entity->getCacheabilityMetadata->applyTo($build)

So the cache tags for each group need to end up on the product, so when a group is modified it will invalidate the product render array

ericchew opened merge request !5

ericchew’s picture

ericchew CreditAttribution: ericchew commented
Status: Active » Needs review

Thanks for the suggestion Matt! It lead to me to figure out the issue and was able to fix it properly within the entity class without a hook.

tonytheferg’s picture

tonytheferg CreditAttribution: tonytheferg commented
Status: Needs review » Reviewed & tested by the community

  • ericchew committed db02f85 on 2.0.x 
    Issue #3191998 by ericchew: Changing discount percentage requires...
ericchew’s picture

ericchew CreditAttribution: ericchew commented
Status: Reviewed & tested by the community » Fixed

Merged!

ericchew’s picture

ericchew CreditAttribution: ericchew commented
tonytheferg’s picture

tonytheferg CreditAttribution: tonytheferg commented
Status: Fixed » Closed (fixed)