Problem/Motivation

  • Add test cases for Ec2Service::addMockHandler()
CommentFileSizeAuthor
#8 3204653-8.patch25.18 KByas
#7 3204653-7.patch.diff23.65 KByas
#6 3204653-6.patch23.65 KByas
#4 3204653-4.patch23.56 KByas
#3 3204653-3.patch23.56 KByas

Issue fork cloud-3204653

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

yas opened merge request !182

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Active » Needs review
FileSize
3204653-3.patch23.56 KB

@kumikoono @xiaohua-guan @baldwinlouie

Could you please review the patch?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
3204653-4.patch23.56 KB

Fixed a typo.

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented

@yas, overall it looks good. I have a comment. Please see the `PR` for details.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
3204653-6.patch23.65 KB

@baldwinlouie

Thank you for your review and finding the issue! I'm fixing it. Hope revised patch passes all the tests.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
3204653-7.patch.diff23.65 KB

Fixing a coding standard violation.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
3204653-8.patch25.18 KB
Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented

@yas

The patch looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for your review. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 6c8a908 on 3.x 
    Issue #3204653 by yas, baldwinlouie, Xiaohua Guan: Add test cases for...

yas closed merge request !182

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.