Rather than implement a custom authmap solution via OpenIDConnectAuthmap, I wonder if it would be beneficial to tap into externalauth and make it a dependency for this project?

https://www.drupal.org/project/externalauth

For an example of this, see ...
https://www.drupal.org/project/externalauth_gitlab

Issue fork openid_connect-3030596

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

matt_paz created an issue. See original summary.

matt_paz’s picture

matt_paz CreditAttribution: matt_paz commented
Issue summary: View changes
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Version: 8.x-1.x-dev » 2.x-dev
Priority: Normal » Major

Yes. I think this makes a LOT of sense.

JeroenT made their first commit to this issue’s fork.

JeroenT opened merge request !13

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented

MR13 removes the OpenIDConnectAuthmap class and replaces it with the externalauth module.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Active » Needs review
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented

Thanks a lot for this work! I think this is RTBC already.

However, since you seem to have stumbled on a bug I introduced in the Accounts form, and fixed it in a way that goes against the purpose of introducing client entities, I'd rather that you either leave the bug in place and open a new issue to fix it correctly, or fix it properly.

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs review » Needs work
JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs work » Needs review

I reverted the change and created a follow-up issue: #3205340: Save ID instead of plugin_id as provider

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented

OK. Then we deal with all these comments in the follow-up issue.. I'll merge this, so that we can work on better code. The joys of being alpha :)

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.