Problem/Motivation

#2332935: Allow code to respond to entity/field schema changes is closed but referenced in a @todo comment in EntityBundleListenerInterface.

Steps to reproduce

Inspect the interface docblock in Drupal\Core\Entity\EntityBundleListenerInterface.

Proposed resolution

Update the @todo to reference #2553169: Dispatch bundle CRUD events which I believe aims to use the Symfony event system for entity bundle operations.

Remaining tasks

Create merge request.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#7 3203147-7.patch531 bytesayushmishra206

Issue fork drupal-3203147

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

richardbporter created an issue. See original summary.

richardbporter opened merge request !415

richardbporter’s picture

richardbporter CreditAttribution: richardbporter as a volunteer commented
Status: Active » Needs review
Issue tags: +Novice
longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

Yeah, that's the correct issue to point to now.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs review

I think this is a case where there just shouldn't be a @todo at all.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Needs work

NW to remove this line entirely.

ayushmishra206’s picture

ayushmishra206 CreditAttribution: ayushmishra206 at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3203147-7.patch531 bytes

Removed the comment as suggested in #5 and #6. Please review.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

Thanks!

  • catch committed affb6d1 on 9.2.x 
    Issue #3203147 by richardbporter, ayushmishra206: Update @todo comment...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed affb6d1 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.