Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Add the identifier to tags in AWS to distinguish multiple Cloud Orchestrator access.
Comment | File | Size | Author |
---|---|---|---|
#23 | 3204816-23.diff | 53.18 KB | sekinet |
Issue fork cloud-3204816
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
sekinet CreditAttribution: sekinet commentedComment #4
sekinet CreditAttribution: sekinet commentedComment #5
sekinet CreditAttribution: sekinet commented@yas I've created a patch, can you check it for me?
Comment #6
yas@sekinet
Thank you for adding the feature. I reviewed and tested the patch. It looks perfect to me.
@xiaohua-guan @baldwinlouie
What do you think?
Comment #7
yas@sekinet
I found some minor issues. Please see my above comments.
Comment #8
sekinet CreditAttribution: sekinet commentedComment #9
baldwinlouie CreditAttribution: baldwinlouie commented@yas and @sekinet, Aside from @yas' comments, the patch looks good.
Comment #10
yas@baldwinlouie
Thank you for your review.
@sekinet
Could you please confirm the leftovers of my comments?
Comment #11
sekinet CreditAttribution: sekinet commentedComment #12
sekinet CreditAttribution: sekinet commentedComment #13
yas@sekinet
Thank you for the update. The tag feature with
UUID
should be applied to the other modules in the future. EspeciallyOpenStack
module should follow the tag scheme like `aws_cloud` module. So could you please add the comment as I commented above?Thanks
Comment #14
sekinet CreditAttribution: sekinet commentedComment #15
sekinet CreditAttribution: sekinet commentedComment #16
sekinet CreditAttribution: sekinet commentedComment #17
sekinet CreditAttribution: sekinet commented@yas Thank you for your comments. Can you please check?
Thanks.
Comment #18
yas@sekinet
Thank you for the update. Now it looks good.
@all
Could you please review the patch?
Thanks
Comment #19
Xiaohua Guan CreditAttribution: Xiaohua Guan commented@yas @sekinet
I post my comment. Please check it. Thanks.
Comment #20
sekinet CreditAttribution: sekinet commentedComment #21
sekinet CreditAttribution: sekinet commented@xiaohua-guan Thank you for your comments. Can you please confirm that you have made the corrections?
Thanks.
Comment #22
yas@sekinet
Could you please rebase your patch's branch?
Comment #23
sekinet CreditAttribution: sekinet commented@yas Thank you for your confirmation, I' ve rebased it.
Comment #24
Xiaohua Guan CreditAttribution: Xiaohua Guan commented@sekinet @yas
It was fixed. Thanks.
Comment #25
yas@xiaohua-guan
Thank you for your confirmation.
@sekinet
I'm changing the status to RTBC.
Comment #26
yas@all
I'll merge the patch to
3.x
and close this issue asFixed
.Comment #29
yas