Problem/Motivation

Add the identifier to tags in AWS to distinguish multiple Cloud Orchestrator access.

Issue fork cloud-3204816

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sekinet created an issue. See original summary.

sekinet’s picture

sekinet’s picture

FileSize
47.26 KB
sekinet’s picture

Status: Active » Needs review

@yas I've created a patch, can you check it for me?

yas’s picture

@sekinet

Thank you for adding the feature. I reviewed and tested the patch. It looks perfect to me.

@xiaohua-guan @baldwinlouie

What do you think?

yas’s picture

Status: Needs review » Needs work

@sekinet

I found some minor issues. Please see my above comments.

sekinet’s picture

baldwinlouie’s picture

@yas and @sekinet, Aside from @yas' comments, the patch looks good.

yas’s picture

@baldwinlouie

Thank you for your review.

@sekinet

Could you please confirm the leftovers of my comments?

sekinet’s picture

sekinet’s picture

FileSize
47.46 KB
yas’s picture

@sekinet

Thank you for the update. The tag feature with UUID should be applied to the other modules in the future. Especially OpenStack module should follow the tag scheme like `aws_cloud` module. So could you please add the comment as I commented above?

Thanks

sekinet’s picture

FileSize
47.43 KB
sekinet’s picture

FileSize
53.7 KB
sekinet’s picture

FileSize
53.88 KB
sekinet’s picture

Status: Needs work » Needs review

@yas Thank you for your comments. Can you please check?
Thanks.

yas’s picture

@sekinet

Thank you for the update. Now it looks good.

@all

Could you please review the patch?

Thanks

Xiaohua Guan’s picture

Status: Needs review » Needs work

@yas @sekinet

I post my comment. Please check it. Thanks.

sekinet’s picture

FileSize
53.88 KB
sekinet’s picture

Status: Needs work » Needs review

@xiaohua-guan Thank you for your comments. Can you please confirm that you have made the corrections?
Thanks.

yas’s picture

Status: Needs review » Needs work
FileSize
53.88 KB

@sekinet

Could you please rebase your patch's branch?

sekinet’s picture

Status: Needs work » Needs review
FileSize
53.18 KB

@yas Thank you for your confirmation, I' ve rebased it.

Xiaohua Guan’s picture

@sekinet @yas

It was fixed. Thanks.

yas’s picture

Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for your confirmation.

@sekinet

I'm changing the status to RTBC.

yas’s picture

@all

I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed 3644ff8 on 3.x authored by sekinet
    Issue #3204816 by sekinet, yas, Xiaohua Guan, baldwinlouie: Add the...

yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.