Tags content too long and leads to horizontal overflow.

CommentFileSizeAuthor
#9 Tag-issue.png229.05 KBMadhu kumar
#7 error.png216.5 KBshalvimukherjee
#5 after-patch.png238.95 KBBhumikaVarshney
#5 before-patch.png189.29 KBBhumikaVarshney
#4 Screenshot 1942-07-02 at 5.26.56 PM.png58.12 KBGauravvvv
#4 issue-resolved-3145757-4.patch262 bytesGauravvvv
#2 tag-issue-resolved-3145757-2.patch241 bytesGauravvvv
Screenshot (129).png43.07 KBGauravvvv
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gauravmahlawat created an issue. See original summary.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv commented
FileSize
tag-issue-resolved-3145757-2.patch241 bytes

I have provided the patch for the issue please verify it. If it is working or not

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv commented
Status: Active » Needs review
Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv commented
FileSize
issue-resolved-3145757-4.patch262 bytes
Screenshot 1942-07-02 at 5.26.56 PM.png58.12 KB

I have provided the patch please review if it is working or not, Adding a after patch screenshot for reference.

BhumikaVarshney’s picture

BhumikaVarshney CreditAttribution: BhumikaVarshney as a volunteer and at OpenSense Labs commented
FileSize
before-patch.png189.29 KB
after-patch.png238.95 KB

Hi @Gauravmahlawat,
Patch works fine for me.
Thanks
RTBC+1

shalvimukherjee’s picture

shalvimukherjee CreditAttribution: shalvimukherjee at QED42 commented
Assigned: Unassigned » shalvimukherjee
shalvimukherjee’s picture

shalvimukherjee CreditAttribution: shalvimukherjee at QED42 commented
FileSize
error.png216.5 KB

At the time of applying patch #4 getting error-

error: while searching for:
margin: 0;
padding: 0;
line-height: 1.5em;
}

/* Text elements

error: patch failed: css/style.css:9
error: css/style.css: patch does not apply

shalvimukherjee’s picture

shalvimukherjee CreditAttribution: shalvimukherjee at QED42 commented
Assigned: shalvimukherjee » Unassigned
Madhu kumar’s picture

Madhu kumar CreditAttribution: Madhu kumar as a volunteer and at Zyxware Technologies commented
FileSize
Tag-issue.png229.05 KB

No such issue founded in 8.x-1.0, I was not able to replicate the issue find below screenshot for your reference and Would appreciate if someone else could help verify if the issue exists.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv commented

Hi @madhu kumar, please refer the screenshot given by me. I am using a single word which doesn’t have any spaces and you’re using different small words. Keep it to only one word and then test it.

Madhu kumar’s picture

Madhu kumar CreditAttribution: Madhu kumar as a volunteer and at Zyxware Technologies commented

Thanks @Gauravmahlawat Without giving space able to replicate the issue.

Gauravvvv’s picture

Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs commented

kunalkapoor’s picture

kunalkapoor CreditAttribution: kunalkapoor at OpenSense Labs commented
Status: Needs review » Fixed
kunalkapoor’s picture

kunalkapoor CreditAttribution: kunalkapoor at OpenSense Labs commented
Status: Fixed » Closed (fixed)