Problem/Motivation

Refactor K8sCloudServerTemplatePlugin::buildLaunchForm() and YamlUrlConstraintValidator::validate() .

CommentFileSizeAuthor
#5 3212680-5.patch21.65 KBMasami
#3 3212680.patch21.98 KBMasami

Issue fork cloud-3212680

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Masami created an issue. See original summary.

Masami opened merge request !224

Masami’s picture

Masami CreditAttribution: Masami commented
Status: Active » Needs review
FileSize
3212680.patch21.98 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Needs work

@masami

Thank you for the patch. I posted my comment above for housekeeping. Thanks

Masami’s picture

Masami CreditAttribution: Masami commented
Status: Needs work » Needs review
FileSize
3212680-5.patch21.65 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. The patch looks good to me. It makes more clear readability. I'll merge the patch to 3.x and close this issue as Fixed.

yas closed merge request !224

  • yas committed 5760438 on 3.x authored by Masami 
    Issue #3212680 by Masami, yas: Refactor K8sCloudServerTemplatePlugin::...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Title: Refactor K8sCloudServerTemplatePlugin::buildLaunchForm() and YamlUrlConstraintValidator::validate() » Refactor K8sCloudServerTemplatePlugin::buildLaunchForm() and YamlUrlConstraintValidator::validate()
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.